chore: move main linting to oxlint (@Miodec) (monkeytypegame#7144)

- main linting is now done by oxlint. eslint remains for linting json
files in the frontend (until oxlint adds support)
 - move type checking to the lint step (with --type-check)
this improves performance by removing a duplicated typescript parse task
(instead of parsing for linting then again for type checking, it parses
once for both)
- add a `lint-fast` npm script to get some fast fail behavior. it simply
lints with no type information
- oxc plugins are still in preview, so the custom plugin that checks for
`__testing` usage outside of tests runs outside the main linting job
until performance is improved
- fixes some type issues (and config issues) that were not visible due
to a missing type check on some files. now type checking will run on
every file that is linted
 - split up oxc config for easier management

waiting oxc-project/tsgolint#494

seeing around 3x improvement in type aware linting

Author: Miodec

.eslintignore

@@ -160,7 +160,7 @@ jobs:
         run: pnpm install
 
       - name: Check lint
-        run: npm run lint-be
+        run: npm run lint-fast-be && npm run lint-be
 
       - name: Build
         run: npm run build-be
@@ -212,7 +212,7 @@ jobs:
         run: pnpm install
 
       - name: Check lint
-        run: npm run lint-fe
+        run: npm run lint-fast-fe && npm run lint-fe
 
       - name: Build
         run: npm run build-fe
@@ -327,7 +327,7 @@ jobs:
         run: pnpm install
 
       - name: Check lint
-        run: npm run lint-pkg
+        run: npm run lint-fast-pkg && npm run lint-pkg
 
       - name: Build
         run: npm run build-pkg

.github/workflows/monkey-ci.yml

@@ -0,0 +1,7 @@
+{
+  "ignorePatterns": ["node_modules", "dist", ".turbo"],
+  "extends": [
+    "./packages/oxlint-config/index.jsonc"
+    // "@monkeytype/oxlint-config"
+  ]
+}

.oxlintrc.json

@@ -0,0 +1,4 @@
+{
+  "ignorePatterns": ["node_modules", "__migration__", "dist", ".turbo"],
+  "extends": ["../packages/oxlint-config/plugin.jsonc"]
+}

backend/.eslintrc.cjs

@@ -1,33 +1,7 @@
 {
+  "ignorePatterns": ["node_modules", "__migration__", "dist", ".turbo"],
   "extends": [
     "../packages/oxlint-config/index.jsonc"
     // "@monkeytype/oxlint-config"
-  ],
-  "overrides": [
-    {
-      "files": ["__tests__/**"],
-      "plugins": [
-        "typescript",
-        "unicorn",
-        "oxc",
-        "import",
-        "node",
-        "promise",
-        "jest",
-        "vitest"
-      ],
-      "rules": {
-        "no-explicit-any": "allow",
-        "explicit-function-return-type": "off",
-        "ban-ts-comment": "off"
-      }
-    },
-    {
-      "files": ["__tests__/**/*.d.ts"],
-      "rules": {
-        "typescript/consistent-type-definitions": "off",
-        "typescript/no-empty-object-type": "off"
-      }
-    }
   ]
 }

backend/.oxlintrc-plugin.json

@@ -10,6 +10,7 @@ import GeorgeQueue from "../../../src/queues/george-queue";
 import * as AuthUtil from "../../../src/utils/auth";
 
 import { enableRateLimitExpects } from "../../__testData__/rate-limit";
+import Test from "supertest/lib/test";
 
 const { mockApp, uid } = setup();
 const configuration = Configuration.getCachedConfiguration();
@@ -558,12 +559,12 @@ describe("AdminController", () => {
     });
   });
 
-  async function expectFailForNonAdmin(call: SuperTest): Promise<void> {
+  async function expectFailForNonAdmin(call: Test): Promise<void> {
     isAdminMock.mockResolvedValue(false);
     const { body } = await call.expect(403);
     expect(body.message).toEqual("You don't have permission to do this.");
   }
-  async function expectFailForDisabledEndpoint(call: SuperTest): Promise<void> {
+  async function expectFailForDisabledEndpoint(call: Test): Promise<void> {
     await enableAdminEndpoints(false);
     const { body } = await call.expect(503);
     expect(body.message).toEqual("Admin endpoints are currently disabled.");

backend/.oxlintrc.json

@@ -33,11 +33,10 @@ import { mockAuthenticateWithApeKey } from "../../__testData__/auth";
 import { randomUUID } from "node:crypto";
 import { MonkeyMail, UserStreak } from "@monkeytype/schemas/users";
 import MonkeyError, { isFirebaseError } from "../../../src/utils/error";
-import { LeaderboardEntry } from "@monkeytype/schemas/leaderboards";
 import * as WeeklyXpLeaderboard from "../../../src/services/weekly-xp-leaderboard";
 import * as ConnectionsDal from "../../../src/dal/connections";
 import { pb } from "../../__testData__/users";
-import { SuperTest } from "supertest";
+import Test from "supertest/lib/test";
 
 const { mockApp, uid, mockAuth } = setup();
 const configuration = Configuration.getCachedConfiguration();
@@ -2979,7 +2978,7 @@ describe("user controller test", () => {
 
       getUserByNameMock.mockResolvedValue(foundUser as any);
 
-      const rank = { rank: 24 } as LeaderboardEntry;
+      const rank = { rank: 24 } as LeaderboardDal.DBLeaderboardEntry;
       leaderboardGetRankMock.mockResolvedValue(rank);
       leaderboardGetCountMock.mockResolvedValue(100);
 
@@ -3041,7 +3040,7 @@ describe("user controller test", () => {
         ...foundUser,
         profileDetails: { showActivityOnPublicProfile: true },
       } as any);
-      const rank = { rank: 24 } as LeaderboardEntry;
+      const rank = { rank: 24 } as LeaderboardDal.DBLeaderboardEntry;
       leaderboardGetRankMock.mockResolvedValue(rank);
       leaderboardGetCountMock.mockResolvedValue(100);
 
@@ -3063,7 +3062,7 @@ describe("user controller test", () => {
         ...foundUser,
         profileDetails: { showActivityOnPublicProfile: false },
       } as any);
-      const rank = { rank: 24 } as LeaderboardEntry;
+      const rank = { rank: 24 } as LeaderboardDal.DBLeaderboardEntry;
       leaderboardGetRankMock.mockResolvedValue(rank);
       leaderboardGetCountMock.mockResolvedValue(100);
 
@@ -3081,7 +3080,7 @@ describe("user controller test", () => {
         banned: true,
       } as any);
 
-      const rank = { rank: 24 } as LeaderboardEntry;
+      const rank = { rank: 24 } as LeaderboardDal.DBLeaderboardEntry;
       leaderboardGetRankMock.mockResolvedValue(rank);
       leaderboardGetCountMock.mockResolvedValue(100);
 
@@ -3132,7 +3131,7 @@ describe("user controller test", () => {
       const uid = foundUser.uid;
       getUserMock.mockResolvedValue(foundUser as any);
 
-      const rank = { rank: 24 } as LeaderboardEntry;
+      const rank = { rank: 24 } as LeaderboardDal.DBLeaderboardEntry;
       leaderboardGetRankMock.mockResolvedValue(rank);
       leaderboardGetCountMock.mockResolvedValue(100);
 
@@ -4050,7 +4049,7 @@ async function enableConnectionsEndpoints(enabled: boolean): Promise<void> {
   );
 }
 
-async function expectFailForDisabledEndpoint(call: SuperTest): Promise<void> {
+async function expectFailForDisabledEndpoint(call: Test): Promise<void> {
   await enableConnectionsEndpoints(false);
   const { body } = await call.expect(503);
   expect(body.message).toEqual("Connections are not available at this time.");

backend/__tests__/api/controllers/admin.spec.ts

@@ -1,7 +1,11 @@
 {
   "extends": "@monkeytype/typescript-config/base.json",
   "compilerOptions": {
-    "noEmit": true
+    "noEmit": true,
+    "noImplicitAny": false,
+    "strictFunctionTypes": false,
+    "useUnknownInCatchVariables": false,
+    "strictPropertyInitialization": false
   },
   "files": ["vitest.d.ts"],
   "include": ["./**/*.ts", "./**/*.spec.ts", "./setup-tests.ts"]

backend/__tests__/api/controllers/user.spec.ts

@@ -4,9 +4,8 @@
   "private": true,
   "license": "GPL-3.0",
   "scripts": {
-    "eslint": "eslint \"./src/**/*.ts\"",
-    "oxlint": "oxlint .",
-    "lint": "npm run oxlint && npm run eslint",
+    "lint": "oxlint . --type-aware --type-check && oxlint -c .oxlintrc-plugin.json",
+    "lint-fast": "oxlint .",
     "build": "npm run gen-docs && tsc --build",
     "watch": "tsc --build --watch",
     "clean": "tsc --build --clean",
@@ -59,7 +58,6 @@
     "zod": "3.23.8"
   },
   "devDependencies": {
-    "@monkeytype/eslint-config": "workspace:*",
     "@monkeytype/oxlint-config": "workspace:*",
     "@monkeytype/typescript-config": "workspace:*",
     "@redocly/cli": "2.0.5",
@@ -81,10 +79,9 @@
     "@types/uuid": "10.0.0",
     "@vitest/coverage-v8": "4.0.8",
     "concurrently": "8.2.2",
-    "eslint": "8.57.1",
-    "eslint-watch": "8.0.0",
     "openapi3-ts": "2.0.2",
-    "oxlint": "1.29.0",
+    "oxlint": "1.33.0",
+    "oxlint-tsgolint": "0.9.0",
     "readline-sync": "1.4.10",
     "supertest": "7.1.4",
     "testcontainers": "11.4.0",