returning false if response was not ok

Miodec · Miodec · commit aa4f0a41f31a · 2023-02-13T15:10:15.000+01:00
diff --git a/backend/src/utils/captcha.ts b/backend/src/utils/captcha.ts
@@ -19,6 +19,11 @@ export async function verify(captcha: string): Promise<boolean> {
       body: `secret=${process.env.RECAPTCHA_SECRET}&response=${captcha}`,
     }
   );
-  const captchaData = (await response.json()) as CaptchaData;
-  return captchaData.success;
+
+  if (!response.ok) {
+    return false;
+  } else {
+    const captchaData = (await response.json()) as CaptchaData;
+    return captchaData.success;
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,11 @@ export async function verify(captcha: string): Promise<boolean> {`
`19`	`19`	body: `secret=${process.env.RECAPTCHA_SECRET}&response=${captcha}`,
`20`	`20`	`}`
`21`	`21`	`);`
`22`		`- const captchaData = (await response.json()) as CaptchaData;`
`23`		`- return captchaData.success;`
	`22`	`+`
	`23`	`+ if (!response.ok) {`
	`24`	`+ return false;`
	`25`	`+ } else {`
	`26`	`+ const captchaData = (await response.json()) as CaptchaData;`
	`27`	`+ return captchaData.success;`
	`28`	`+ }`
`24`	`29`	`}`