impr(results): allow PBs with stop on letter if accuracy is 100% (@byseif21) (monkeytypegame#6611)

Author: byseif21

backend/src/api/controllers/result.ts

@@ -488,13 +488,16 @@ export async function addResult(
 
   let dailyLeaderboardRank = -1;
 
+  const stopOnLetterTriggered =
+    completedEvent.stopOnLetter && completedEvent.acc < 100;
+
   const validResultCriteria =
     canFunboxGetPb(completedEvent) &&
     !completedEvent.bailedOut &&
     user.banned !== true &&
     user.lbOptOut !== true &&
     (isDevEnvironment() || (user.timeTyping ?? 0) > 7200) &&
-    !completedEvent.stopOnLetter;
+    !stopOnLetterTriggered;
 
   const selectedBadgeId = user.inventory?.badges?.find((b) => b.selected)?.id;
   const isPremium =

backend/src/dal/user.ts

@@ -454,7 +454,12 @@ export async function checkIfPb(
   const { mode } = result;
 
   if (!canFunboxGetPb(result)) return false;
-  if ("stopOnLetter" in result && result.stopOnLetter === true) return false;
+  if (
+    "stopOnLetter" in result &&
+    result.stopOnLetter === true &&
+    result.acc < 100
+  )
+    return false;
 
   if (mode === "quote") {
     return false;
@@ -500,7 +505,12 @@ export async function checkIfTagPb(
 
   const { mode, tags: resultTags } = result;
   if (!canFunboxGetPb(result)) return [];
-  if ("stopOnLetter" in result && result.stopOnLetter === true) return [];
+  if (
+    "stopOnLetter" in result &&
+    result.stopOnLetter === true &&
+    result.acc < 100
+  )
+    return [];
 
   if (mode === "quote") {
     return [];

frontend/src/ts/test/result.ts

@@ -483,10 +483,12 @@ async function resultCanGetPb(): Promise<CanGetPbObject> {
   const allFunboxesCanGetPb = funboxObjects.every((f) => f?.canGetPb);
 
   const funboxesOk = funboxes.length === 0 || allFunboxesCanGetPb;
-  const notUsingStopOnLetter = Config.stopOnError !== "letter";
+  // allow stopOnError:letter to be PB only if 100% accuracy, since it doesn't affect gameplay
+  const stopOnLetterTriggered =
+    Config.stopOnError === "letter" && result.acc < 100;
   const notBailedOut = !result.bailedOut;
 
-  if (funboxesOk && notUsingStopOnLetter && notBailedOut) {
+  if (funboxesOk && !stopOnLetterTriggered && notBailedOut) {
     return {
       value: true,
     };
@@ -497,7 +499,7 @@ async function resultCanGetPb(): Promise<CanGetPbObject> {
         reason: "funbox",
       };
     }
-    if (!notUsingStopOnLetter) {
+    if (stopOnLetterTriggered) {
       return {
         value: false,
         reason: "stop on letter",