chore: bump eslint typescript plugin (@Miodec) (monkeytypegame#6915)

Author: Miodec

.eslintignore

@@ -4,3 +4,4 @@ docker
 backend/scripts
 backend/private
 **/vitest.config.ts
+node_modules

backend/src/dal/leaderboards.ts

@@ -226,7 +226,7 @@ export async function update(
   //update speedStats
   const boundaries = [...Array(32).keys()].map((it) => it * 10);
   const statsKey = `${language}_${mode}_${mode2}`;
-  const src = await db.collection(lbCollectionName);
+  const src = db.collection(lbCollectionName);
   const histogram = src.aggregate(
     [
       {

backend/src/dal/new-quotes.ts

@@ -187,6 +187,7 @@ export async function approve(
       if (compareTwoStrings(old.text, quote.text) > 0.8) {
         throw new MonkeyError(409, "Duplicate quote");
       }
+      return true;
     });
     let maxid = 0;
     quoteObject.quotes.map(function (q) {

frontend/src/ts/controllers/ad-controller.ts

@@ -316,7 +316,7 @@ BannerEvent.subscribe(() => {
   updateVerticalMargin();
 });
 
-$(document).ready(() => {
+$(() => {
   updateBreakpoint(true);
   updateBreakpoint2();
 });

frontend/src/ts/controllers/input-controller.ts

@@ -72,10 +72,7 @@ function updateUI(): void {
   if (Config.keymapMode === "next" && Config.mode !== "zen") {
     if (!Config.language.startsWith("korean")) {
       void KeymapEvent.highlight(
-        TestWords.words
-          .getCurrent()
-          .charAt(TestInput.input.current.length)
-          .toString()
+        TestWords.words.getCurrent().charAt(TestInput.input.current.length)
       );
     } else {
       //word [가다]
@@ -1194,10 +1191,7 @@ $(document).on("keydown", async (event) => {
 
   if (
     Config.layout !== "default" &&
-    !(
-      event.ctrlKey ||
-      (event.altKey && window.navigator.platform.search("Linux") > -1)
-    )
+    !(event.ctrlKey || (event.altKey && Misc.isLinux()))
   ) {
     const char: string | null = await LayoutEmulator.getCharFromEvent(event);
     if (char !== null) {
@@ -1217,6 +1211,8 @@ $("#wordsInput").on("keydown", (event) => {
       "spacing debug keydown STOPPED - repeat",
       event.key,
       event.code,
+      //ignore for logging
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       event.which
     );
     return;
@@ -1236,7 +1232,7 @@ $("#wordsInput").on("keydown", (event) => {
   const now = performance.now();
   setTimeout(() => {
     const eventCode =
-      event.code === "" || event.which === 231 ? "NoCode" : event.code;
+      event.code === "" || event.key === "Unidentified" ? "NoCode" : event.code;
     TestInput.recordKeydownTime(now, eventCode);
   }, 0);
 });
@@ -1247,6 +1243,8 @@ $("#wordsInput").on("keyup", (event) => {
       "spacing debug keydown STOPPED - repeat",
       event.key,
       event.code,
+      //ignore for logging
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       event.which
     );
     return;
@@ -1265,7 +1263,7 @@ $("#wordsInput").on("keyup", (event) => {
   const now = performance.now();
   setTimeout(() => {
     const eventCode =
-      event.code === "" || event.which === 231 ? "NoCode" : event.code;
+      event.code === "" || event.key === "Unidentified" ? "NoCode" : event.code;
     TestInput.recordKeyupTime(now, eventCode);
   }, 0);
 });

frontend/src/ts/controllers/route-controller.ts

@@ -171,7 +171,8 @@ export async function navigate(
     Notifications.add("No quit funbox is active. Please finish the test.", 0, {
       important: true,
     });
-    event?.preventDefault();
+    //todo: figure out if this was ever used
+    // event?.preventDefault();
     return;
   }
 

frontend/src/ts/elements/account/result-filters.ts

@@ -697,7 +697,7 @@ function selectBeforeChangeFn(
   group: ResultFiltersGroup,
   selectedOptions: Option[],
   oldSelectedOptions: Option[]
-): void | boolean {
+): boolean {
   const includesAllNow = selectedOptions.some(
     (option) => option.value === "all"
   );
@@ -819,7 +819,7 @@ export async function appendButtons(
       closeOnSelect: false,
     },
     events: {
-      beforeChange: (selectedOptions, oldSelectedOptions): void | boolean => {
+      beforeChange: (selectedOptions, oldSelectedOptions): boolean => {
         return selectBeforeChangeFn(
           "language",
           selectedOptions,
@@ -851,7 +851,7 @@ export async function appendButtons(
       closeOnSelect: false,
     },
     events: {
-      beforeChange: (selectedOptions, oldSelectedOptions): void | boolean => {
+      beforeChange: (selectedOptions, oldSelectedOptions): boolean => {
         return selectBeforeChangeFn(
           "funbox",
           selectedOptions,
@@ -889,10 +889,7 @@ export async function appendButtons(
           closeOnSelect: false,
         },
         events: {
-          beforeChange: (
-            selectedOptions,
-            oldSelectedOptions
-          ): void | boolean => {
+          beforeChange: (selectedOptions, oldSelectedOptions): boolean => {
             return selectBeforeChangeFn(
               "tags",
               selectedOptions,

frontend/src/ts/elements/keymap.ts

@@ -477,7 +477,7 @@ export async function refresh(): Promise<void> {
   }
 }
 
-const isMacLike = /Mac|iPod|iPhone|iPad/.test(navigator.platform);
+const isMacLike = Misc.isMacLike();
 const symbolsPattern = /^[^\p{L}\p{N}]{1}$/u;
 type KeymapLegendStates = [letters: 0 | 1 | 2 | 3, symbols: 0 | 1 | 2 | 3];
 let keymapLegendStates: KeymapLegendStates = [0, 0];

frontend/src/ts/firebase.ts

@@ -172,7 +172,7 @@ export async function createUserWithEmailAndPassword(
 }
 
 export async function getIdToken(): Promise<string | null> {
-  const user = await getAuthenticatedUser();
+  const user = getAuthenticatedUser();
   if (user === null) return null;
   return firebaseGetIdToken(user);
 }

frontend/src/ts/modals/custom-text.ts

@@ -555,21 +555,21 @@ async function setup(modalEl: HTMLElement): Promise<void> {
   });
   modalEl.querySelector(".button.wordfilter")?.addEventListener("click", () => {
     void WordFilterPopup.show({
-      modalChain: modal as AnimatedModal<unknown, unknown>,
+      modalChain: modal as AnimatedModal,
     });
   });
   modalEl
     .querySelector(".button.showSavedTexts")
     ?.addEventListener("click", () => {
       void SavedTextsPopup.show({
-        modalChain: modal as AnimatedModal<unknown, unknown>,
+        modalChain: modal as AnimatedModal,
       });
     });
   modalEl
     .querySelector(".button.saveCustomText")
     ?.addEventListener("click", () => {
       void SaveCustomTextPopup.show({
-        modalChain: modal as AnimatedModal<unknown, unknown>,
+        modalChain: modal as AnimatedModal,
         modalChainData: { text: cleanUpText() },
       });
     });