CI: Apply Go linter recommendations to "internal/thumb/..." photoprism#5330

Signed-off-by: Michael Mayer <michael@photoprism.app>

Author: lastzero

internal/thumb/avatar/avatar.go

@@ -25,13 +25,13 @@ Additional information can be found in our Developer Guide:
 package avatar
 
 import (
-	_ "image/gif"
-	_ "image/jpeg"
-	_ "image/png"
+	_ "image/gif"  // register gif decoder
+	_ "image/jpeg" // register jpeg decoder
+	_ "image/png"  // register png decoder
 
-	_ "golang.org/x/image/bmp"
-	_ "golang.org/x/image/tiff"
-	_ "golang.org/x/image/webp"
+	_ "golang.org/x/image/bmp"  // register bmp decoder
+	_ "golang.org/x/image/tiff" // register tiff decoder
+	_ "golang.org/x/image/webp" // register webp decoder
 
 	"github.com/photoprism/photoprism/internal/event"
 )

internal/thumb/avatar/download_test.go

@@ -63,7 +63,7 @@ func TestSafeDownload_Succeeds(t *testing.T) {
 	if err := SafeDownload(dest, ts.URL, &safe.Options{Timeout: 5 * time.Second, MaxSizeBytes: 1 << 20, AllowPrivate: true}); err != nil {
 		t.Fatalf("unexpected error: %v", err)
 	}
-	b, err := os.ReadFile(dest)
+	b, err := os.ReadFile(dest) //nolint:gosec // test reads temp file
 	if err != nil {
 		t.Fatalf("read: %v", err)
 	}

internal/thumb/crop/errors.go

@@ -5,5 +5,6 @@ import (
 )
 
 var (
+	// ErrNotFound indicates the requested crop size or option was not found.
 	ErrNotFound = errors.New("not found")
 )

internal/thumb/crop/image.go

@@ -154,12 +154,13 @@ func findIdealThumbFileName(hash string, width int, filePath string) (fileName s
 		// Resolve symlinks.
 		name, err := fs.Resolve(filepath.Join(filePath, fmt.Sprintf(thumbFileNames[i], hash)))
 
-		if err != nil || !fs.FileExists(name) {
+		switch {
+		case err != nil || !fs.FileExists(name):
 			continue
-		} else if s.Width < width {
+		case s.Width < width:
 			fileName = name
 			continue
-		} else {
+		default:
 			return name
 		}
 	}
@@ -176,7 +177,7 @@ func openIdealThumbFile(fileName, hash string, area Area, size Size) (result ima
 
 	if len(hash) != 40 || area.W <= 0 || size.Width <= 0 {
 		// Not a standard thumb name with sha1 hash prefix.
-		if imageBuffer, err := os.ReadFile(fileName); err != nil {
+		if imageBuffer, err := os.ReadFile(fileName); err != nil { //nolint:gosec // file path comes from resolved thumbnails
 			return nil, err
 		} else {
 			return imaging.Decode(bytes.NewReader(imageBuffer), imaging.AutoOrientation(true))
@@ -187,7 +188,7 @@ func openIdealThumbFile(fileName, hash string, area Area, size Size) (result ima
 		fileName = name
 	}
 
-	if imageBuffer, err := os.ReadFile(fileName); err != nil {
+	if imageBuffer, err := os.ReadFile(fileName); err != nil { //nolint:gosec // file path comes from resolved thumbnails
 		return nil, err
 	} else {
 		return imaging.Decode(bytes.NewReader(imageBuffer))

internal/thumb/crop/request.go

@@ -31,7 +31,7 @@ func FromRequest(hash, area string, size Size, thumbPath string) (fileName strin
 	cropBase := fmt.Sprintf("%s_%dx%d_crop_%s%s", hash, size.Width, size.Height, area, fs.ExtJpeg)
 	cropName := filepath.Join(filepath.Dir(thumbName), cropBase)
 
-	imageBuffer, err := os.ReadFile(thumbName)
+	imageBuffer, err := os.ReadFile(thumbName) //nolint:gosec // thumbName resolved from validated cache path
 
 	if err != nil {
 		return "", err

internal/thumb/crop/sizes.go

@@ -3,9 +3,11 @@ package crop
 import "github.com/photoprism/photoprism/internal/thumb"
 
 var (
+	// DefaultOptions are the resample options applied to most crop sizes.
 	DefaultOptions = []thumb.ResampleOption{thumb.ResampleFillCenter, thumb.ResampleDefault}
 )
 
+// Size defines a thumbnail size and resample options.
 type Size struct {
 	Name    Name                   `json:"name"`
 	Source  Name                   `json:"-"`
@@ -15,6 +17,7 @@ type Size struct {
 	Options []thumb.ResampleOption `json:"-"`
 }
 
+// SizeMap maps size names to size definitions.
 type SizeMap map[Name]Size
 
 // Sizes contains the properties of all thumbnail sizes.

internal/thumb/frame/angle.go

@@ -20,5 +20,5 @@ func RandomAngle(max float64) float64 {
 
 	r := 2 * max
 
-	return (rand.Float64() - 0.5) * r
+	return (rand.Float64() - 0.5) * r //nolint:gosec // visual randomness only
 }

internal/thumb/frame/frame.go

@@ -24,6 +24,8 @@ Additional information can be found in our Developer Guide:
 */
 package frame
 
+// Type defines the frame style identifier.
 type Type string
 
+// Polaroid represents the Polaroid-style frame type.
 const Polaroid = "polaroid"

internal/thumb/frame/point.go

@@ -16,14 +16,14 @@ func RandomPoint(xMin, yMin, xMax, yMax int) image.Point {
 	}
 
 	xDiff := float64(xMax - xMin)
-	x := xMin + int(rand.Float64()*xDiff)
+	x := xMin + int(rand.Float64()*xDiff) //nolint:gosec // visual randomness only
 
 	if yMin > yMax {
 		yMin = yMax
 	}
 
 	yDiff := float64(yMax - yMin)
-	y := yMin + int(rand.Float64()*yDiff)
+	y := yMin + int(rand.Float64()*yDiff) //nolint:gosec // visual randomness only
 
 	return image.Pt(x, y)
 }