Skip to content

Commit ddc37e0

Browse files
committed
API: Improve audit logs in cluster_nodes_register.go
Signed-off-by: Michael Mayer <michael@photoprism.app>
1 parent c5b5fee commit ddc37e0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

internal/api/cluster_nodes_register.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ func ClusterNodesRegister(router *gin.RouterGroup) {
154154
// If caller attempts to change UUID by name without proving client secret, block with 409.
155155
if RegisterRequireClientSecret {
156156
if requestedUUID != "" && n.UUID != "" && requestedUUID != n.UUID && req.ClientID == "" {
157-
event.AuditWarn([]string{clientIp, string(acl.ResourceCluster), "node %s uuid change requires client secret", event.Denied}, clean.Log(name))
157+
event.AuditWarn([]string{clientIp, string(acl.ResourceCluster), "node %s", "invalid client secret", event.Denied}, clean.Log(name))
158158
c.JSON(http.StatusConflict, gin.H{"error": "client secret required to change node uuid"})
159159
return
160160
}
@@ -206,7 +206,7 @@ func ClusterNodesRegister(router *gin.RouterGroup) {
206206
return
207207
}
208208
respSecret = &cluster.RegisterSecrets{ClientSecret: n.ClientSecret, RotatedAt: n.RotatedAt}
209-
event.AuditInfo([]string{clientIp, string(acl.ResourceCluster), "node %s rotate secret", event.Succeeded}, clean.Log(name))
209+
event.AuditInfo([]string{clientIp, string(acl.ResourceCluster), "node %s", "rotate secret", event.Succeeded}, clean.Log(name))
210210

211211
// Extra safety: ensure the updated secret is persisted even if subsequent steps fail.
212212
if putErr := regy.Put(n); putErr != nil {
@@ -239,7 +239,7 @@ func ClusterNodesRegister(router *gin.RouterGroup) {
239239
AbortUnexpectedError(c)
240240
return
241241
}
242-
event.AuditInfo([]string{clientIp, string(acl.ResourceCluster), "node %s rotate database", event.Succeeded}, clean.Log(name))
242+
event.AuditInfo([]string{clientIp, string(acl.ResourceCluster), "node %s", "rotate database", event.Succeeded}, clean.Log(name))
243243
}
244244
}
245245

0 commit comments

Comments
 (0)