Fix crash after changing syntax highlight setting (#7)

Author: luizzeroxis

UndertaleModToolAvalonia/ResourceViews/UndertaleCodeView.axaml.cs

@@ -35,12 +35,20 @@ public partial class UndertaleCodeView : UserControl, IUndertaleCodeView
 
     private readonly List<string> codeLocalsCache = new();
 
+    private readonly NumberGenerator gmlNumberGenerator;
+    private readonly NameGenerator gmlNameGenerator;
+    private readonly NameGenerator asmNameGenerator;
+
     public (int, int) LastCaretOffsets;
 
     public UndertaleCodeView()
     {
         InitializeComponent();
 
+        gmlNumberGenerator = new(this);
+        gmlNameGenerator = new(this);
+        asmNameGenerator = new(this);
+
         DataContextChanged += (_, __) =>
         {
             if (DataContext is UndertaleCodeViewModel vm)
@@ -63,17 +71,25 @@ public UndertaleCodeView()
                     UndertaleCodeView.ASMHighlightingDefinition ??= LoadHighlightingDefinition("ASM");
                     ASMTextEditor.SyntaxHighlighting = UndertaleCodeView.ASMHighlightingDefinition;
 
-                    GMLTextEditor.TextArea.TextView.ElementGenerators.Add(new NumberGenerator(this));
-                    GMLTextEditor.TextArea.TextView.ElementGenerators.Add(new NameGenerator(this));
+                    if (!GMLTextEditor.TextArea.TextView.ElementGenerators.Contains(gmlNumberGenerator))
+                        GMLTextEditor.TextArea.TextView.ElementGenerators.Add(gmlNumberGenerator);
+
+                    if (!GMLTextEditor.TextArea.TextView.ElementGenerators.Contains(gmlNameGenerator))
+                        GMLTextEditor.TextArea.TextView.ElementGenerators.Add(gmlNameGenerator);
 
-                    ASMTextEditor.TextArea.TextView.ElementGenerators.Add(new NameGenerator(this));
+                    if (!ASMTextEditor.TextArea.TextView.ElementGenerators.Contains(asmNameGenerator))
+                        ASMTextEditor.TextArea.TextView.ElementGenerators.Add(asmNameGenerator);
                 }
                 else
                 {
                     GMLTextEditor.SyntaxHighlighting = null;
                     ASMTextEditor.SyntaxHighlighting = null;
                     UndertaleCodeView.GMLHighlightingDefinition = null;
                     UndertaleCodeView.ASMHighlightingDefinition = null;
+
+                    GMLTextEditor.TextArea.TextView.ElementGenerators.Remove(gmlNumberGenerator);
+                    GMLTextEditor.TextArea.TextView.ElementGenerators.Remove(gmlNameGenerator);
+                    ASMTextEditor.TextArea.TextView.ElementGenerators.Remove(asmNameGenerator);
                 }
 
                 if (this.IsAttachedToVisualTree())
@@ -136,9 +152,16 @@ void UpdateHighlightingCache()
         if (DataContext is not UndertaleCodeViewModel vm)
             return;
 
-        UndertaleData data = vm.MainVM.Data!;
-
         ScriptsCache.Clear();
+        FunctionsCache.Clear();
+        CodeCache.Clear();
+        NamedResourcesCache.Clear();
+        codeLocalsCache.Clear();
+
+        if (!vm.MainVM.Settings!.EnableSyntaxHighlighting)
+            return;
+
+        UndertaleData data = vm.MainVM.Data!;
 
         foreach (var script in data.Scripts)
         {
@@ -147,24 +170,20 @@ void UpdateHighlightingCache()
             ScriptsCache[script.Name.Content] = script;
         }
 
-        FunctionsCache.Clear();
         foreach (var function in data.Functions)
         {
             if (function is null)
                 continue;
             FunctionsCache[function.Name.Content] = function;
         }
 
-        CodeCache.Clear();
         foreach (var code in data.Code)
         {
             if (code is null)
                 continue;
             CodeCache[code.Name.Content] = code;
         }
 
-        NamedResourcesCache.Clear();
-
         // NOTE: Remember to add new types
         IEnumerable?[] objLists = [
             data.Sounds,
@@ -195,8 +214,6 @@ void UpdateHighlightingCache()
             }
         }
 
-        codeLocalsCache.Clear();
-
         UndertaleCodeLocals? locals = data.CodeLocals?.ByName(vm.Code.Name.Content);
         if (locals != null)
         {
@@ -323,7 +340,6 @@ public class NumberGenerator : VisualLineElementGenerator
         public NumberGenerator(UndertaleCodeView codeView)
         {
             this.codeView = codeView;
-
             contextMenu.Placement = PlacementMode.Pointer;
         }