Skip to content

Regression has been introduced with commit 630f9e4 when using the "Open Folder" action #1278

@VizuaaLOG

Description

@VizuaaLOG

Expected Behavior

Clicking the "Open Folder" button, with a folder selected, will go into the folder. This is how the UI behaved prior to this commit.

Actual Behavior

Selecting a folder, and clicking "Open Folder" will cause a new tab to be opened to a "[object%20Object]" URL.

Steps to Reproduce the Problem

  1. Open the file manager UI to a location that has at least one folder
  2. Select the folder
  3. Click "Open Folder" at the bottom of the UI, which is shown when a folder is selected

Specifications

  • Operating system : Reproduced on Windows 11
  • Laravel version : 12.42.0
  • Package version : 2.12.1
  • Screenshots of browser console : No errors

Additional Notes

While investigating this issue for a client, I have noticed that the behaviour of how the actions work would make it appear that this method is unused. All actions with data-action are just mapped to window[$this.data('action'). Open, exists as a native action in browsers, and will open to the URL. However, before the referenced commit open was being replaced with that function. Meaning that for a folder, it would open the folder, as it was simply mapped to goTo.

With the removal of the open method, the native browser open is called, but is passed an object not a url.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions