-
Notifications
You must be signed in to change notification settings - Fork 740
Description
Expected Behavior
Clicking the "Open Folder" button, with a folder selected, will go into the folder. This is how the UI behaved prior to this commit.
Actual Behavior
Selecting a folder, and clicking "Open Folder" will cause a new tab to be opened to a "[object%20Object]" URL.
Steps to Reproduce the Problem
- Open the file manager UI to a location that has at least one folder
- Select the folder
- Click "Open Folder" at the bottom of the UI, which is shown when a folder is selected
Specifications
- Operating system : Reproduced on Windows 11
- Laravel version : 12.42.0
- Package version : 2.12.1
- Screenshots of browser console : No errors
Additional Notes
While investigating this issue for a client, I have noticed that the behaviour of how the actions work would make it appear that this method is unused. All actions with data-action are just mapped to window[$this.data('action'). Open, exists as a native action in browsers, and will open to the URL. However, before the referenced commit open was being replaced with that function. Meaning that for a folder, it would open the folder, as it was simply mapped to goTo.
With the removal of the open method, the native browser open is called, but is passed an object not a url.