Fix netCDF-C loading in RuntimeConfigParser

Use the correct method name when loading the library by name and path.
Fixes #1473

Author: lesserwhirls

cdm/core/src/main/java/ucar/nc2/NetcdfFileWriter.java

@@ -194,7 +194,6 @@ protected NetcdfFileWriter(Version version, String location, boolean isExisting,
     if (version.useJniIosp()) {
       IOServiceProviderWriter spi;
       try {
-        // Nc4Iosp.setLibraryAndPath(path, name);
         Class iospClass = this.getClass().getClassLoader().loadClass("ucar.nc2.jni.netcdf.Nc4Iosp");
         Constructor<IOServiceProviderWriter> ctor = iospClass.getConstructor(Version.class);
         spi = ctor.newInstance(version);

cdm/core/src/main/java/ucar/nc2/util/xml/RuntimeConfigParser.java

@@ -269,7 +269,7 @@ public static void read(org.jdom2.Element root, StringBuilder errlog) {
           // so we cannot refer to the Nc4Iosp.class and NetcdfClibrary.class object.
           String nc4IospClassName = "ucar.nc2.jni.netcdf.Nc4Iosp";
           // The setLibraryAndPath method from Nc4Iosp has been deprecated
-          // and splited into separated class: NetcdfClibrary
+          // and split into separated class: NetcdfClibrary
           String netcdfClibraryClassName = "ucar.nc2.ffi.netcdf.NetcdfClibrary";
           /*
            * <Netcdf4Clibrary>
@@ -285,8 +285,8 @@ public static void read(org.jdom2.Element root, StringBuilder errlog) {
           if (path != null && name != null) {
             // reflection is used to decouple optional jars
             try {
-              Class netcdfClibraryClass = RuntimeConfigParser.class.getClassLoader().loadClass(netcdfClibraryClassName);
-              Method method = netcdfClibraryClass.getMethod("setLibraryAndPath", String.class, String.class);
+              Class<?> netcdfClibraryClass = RuntimeConfigParser.class.getClassLoader().loadClass(netcdfClibraryClassName);
+              Method method = netcdfClibraryClass.getMethod("setLibraryNameAndPath", String.class, String.class);
               method.invoke(null, path, name); // static method has null for object
             } catch (Throwable e) {
               errlog.append(netcdfClibraryClassName + " is not on classpath\n");