Merge pull request #1409 from michaeldiener/maint-5.x_sigmetfix

cdm-radial: fix for sigmet volume scan

Author: lesserwhirls

cdm/radial/src/main/java/ucar/nc2/iosp/sigmet/SigmetIOServiceProvider.java

@@ -350,7 +350,8 @@ public ArrayList<Variable> init(RandomAccessFile raf, ucar.nc2.NetcdfFile ncfile
       var_name = var_name_original;
       int bytesPerBin = 1;
       List<List<Ray>> allRays = volScan.getGroup(data_name[dty]);
-      if (allRays.size() > 0 && allRays.get(0).size() > 0)
+      if (allRays != null && allRays.size() > 0 && allRays.get(0) != null && allRays.get(0).size() > 0
+          && allRays.get(0).get(0) != null)
         bytesPerBin = allRays.get(0).get(0).getBytesPerBin();
 
       DataType dType = calcDataType(dty, bytesPerBin);

cdm/radial/src/main/java/ucar/nc2/iosp/sigmet/SigmetVolumeScan.java

@@ -224,7 +224,7 @@ public class SigmetVolumeScan {
       cur_len = len;
 
       if (nsweep == number_sweeps & rays_count == beg) {
-        return;
+        break;
       }
 
       if (beg_rec) {

cdm/radial/src/test/data/sigmet/BAR250130122328.RAWK8Y1

@@ -0,0 +1,4 @@
+Creative Commons Attribution 4.0 International (CC BY 4.0)
+https://creativecommons.org/licenses/by/4.0/deed
+
+IDEAM - Colombian Radar Network was accessed on 2025/01/30 from https://registry.opendata.aws/ideam-radares .

cdm/radial/src/test/data/sigmet/BAR250130122328.RAWK8Y1.README

@@ -0,0 +1,60 @@
+package ucar.nc2.iosp.sigmet;
+
+import org.apache.commons.io.filefilter.WildcardFileFilter;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import ucar.nc2.NetcdfFile;
+import ucar.nc2.NetcdfFiles;
+import ucar.unidata.util.test.TestDir;
+
+import java.io.IOException;
+import java.lang.invoke.MethodHandles;
+import java.util.ArrayList;
+import java.util.Collection;
+
+@RunWith(Parameterized.class)
+public class TestIdeamCo {
+  private static final Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+  String filename;
+
+  @Parameterized.Parameters(name = "{0}")
+  public static Collection<Object[]> getTestParameters() throws IOException {
+    final Collection<Object[]> filenames = new ArrayList<>();
+
+    try {
+      TestDir.actOnAll(TestDir.localTestDataDir + "sigmet/", new WildcardFileFilter("BAR250130122328.RAWK8Y1"),
+          new TestDir.Act() {
+            public int doAct(String filename) throws IOException {
+              filenames.add(new Object[] {filename});
+              return 1;
+            }
+          }, true);
+    } catch (IOException e) {
+      // JUnit *always* executes a test class's @Parameters method, even if it won't subsequently run the class's tests
+      // due to an @Category exclusion. Therefore, we must not let it throw an exception, or else we'll get a build
+      // failure. Instead, we return a collection containing a nonsense value (to wit, the exception message).
+      //
+      // Naturally, if we execute a test using that nonsense value, it'll fail. That's fine; we need to deal with the
+      // root cause. However, it is more likely that the exception occurred because "!isCdmUnitTestDirAvailable", and
+      // as a result, all NeedsCdmUnitTest tests will be excluded.
+      filenames.add(new Object[] {e.getMessage()});
+    }
+
+    return filenames;
+  }
+
+  public TestIdeamCo(String filename) {
+    this.filename = filename;
+  }
+
+  @Test
+  public void testOpen() throws IOException {
+    try (NetcdfFile nc = NetcdfFiles.open(filename)) {
+
+    }
+  }
+}