sourceSet modification no longer needed post proto plugin upgrade

lesserwhirls · lesserwhirls · commit c4bc5994cf85 · 2025-07-31T10:01:51.000-06:00
diff --git a/gradle/any/protobuf.gradle b/gradle/any/protobuf.gradle
@@ -8,14 +8,6 @@ protobuf {
   }
 }
 
-// Add generated sources to the main sourceSet, which keeps intellij happy.
-// Now, we could use the idea plugin and let gradle generate intellij project files, but it seems as though gradle is
-// considering deprecating their plugin and upstreaming it to JetBrains. Might not be a good bet to start relying on
-// the idea plugin at this point.
-// https://github.com/gradle/gradle/issues/1366#issuecomment-546928184
-sourceSets.main.java.srcDirs += ['build/generated/sources/proto/main/java',
-                                 'build/generated/sources/proto/main/grpc']
-
 jacocoTestReport {
   afterEvaluate {
     // Exclude proto generated sources and classes from the coverage reports

Original file line number	Diff line number	Diff line change
`@@ -8,14 +8,6 @@ protobuf {`
`8`	`8`	`}`
`9`	`9`	`}`
`10`	`10`
`11`		`-// Add generated sources to the main sourceSet, which keeps intellij happy.`
`12`		`-// Now, we could use the idea plugin and let gradle generate intellij project files, but it seems as though gradle is`
`13`		`-// considering deprecating their plugin and upstreaming it to JetBrains. Might not be a good bet to start relying on`
`14`		`-// the idea plugin at this point.`
`15`		`-// https://github.com/gradle/gradle/issues/1366#issuecomment-546928184`
`16`		`-sourceSets.main.java.srcDirs += ['build/generated/sources/proto/main/java',`
`17`		`- 'build/generated/sources/proto/main/grpc']`
`18`		`-`
`19`	`11`	`jacocoTestReport {`
`20`	`12`	`afterEvaluate {`
`21`	`13`	`// Exclude proto generated sources and classes from the coverage reports`