Skip to content

Commit 450e798

Browse files
committed
improve build
1 parent 2e3e97d commit 450e798

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

esbuild.js

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { execSync } from 'child_process';
44
import { resolve } from 'path';
55
import { performance } from 'perf_hooks';
66

7-
const { emptyDir, copy, readJson, writeJson } = fse;
7+
const { emptyDir, readJson } = fse;
88

99
const startTime = performance.now();
1010
const pkg = await readJson('./package.json');
@@ -34,17 +34,6 @@ esbuild
3434
// Build declaration files with TSC since they aren't built by esbuild.
3535
execSync('npx tsc');
3636

37-
const declarationsDir = resolve(distDir, 'src');
38-
39-
// Move all declaration files to the root dist folder. Also remove unwanted files and folder.
40-
// await remove(resolve(declarationsDir, 'cli.d.ts'));
41-
await copy(declarationsDir, distDir);
42-
// await remove(declarationsDir);
43-
44-
await writeJson(resolve(distDir, 'package.json'), distPackage, {
45-
spaces: 2,
46-
});
47-
4837
const buildTime = ((performance.now() - startTime) / 1000).toLocaleString(
4938
'en-US',
5039
{

src/howl.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1633,8 +1633,8 @@ class Howl {
16331633
// Clear out `this`.
16341634
this._state = 'unloaded';
16351635
this._sounds = [];
1636-
// @ts-expect-error Temporarily ignore strict type checking to allow dynamic JS
1637-
this = null;
1636+
// NOTE: This is operation is not allowed in modern TS + JS. Don't know how to replace it though.
1637+
// this = null;
16381638

16391639
return null;
16401640
}

0 commit comments

Comments
 (0)