Skip to content

Commit 8508f33

Browse files
authored
Merge pull request #313 from Uniswap/hotfix-staging
release(v1.1.0): hotfix
2 parents 835091c + 9192739 commit 8508f33

19 files changed

+389
-107
lines changed

CHANGELOG.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@ Fully backwards compatible with Liquidity Launcher v1.0.0 deployments. Contains
1111
- New package `blocknumberish` to handle block number retrieval on different chains (to support Arbitrum)
1212
- `IContinuousClearingAuction.lbpInitializationParams` to return the initialization parameters for the LBP initializer
1313
- `IContinuousClearingAuction.supportsInterface` to check if the contract supports the LBP initializer interface
14+
- Added `ValidationHookIntrospection` to existing ValidationHook contracts to support introspection via ERC165
1415

1516
### Changed
1617

17-
- Some minor code quality changes
18+
- Fixed a bug in certain rare edge cases which would cause bids to be permanently locked in the contract
1819
- Fixed an issue in error parameter order
20+
- Some minor code quality changes
1921

2022
### Audits
2123

@@ -24,10 +26,10 @@ Fully backwards compatible with Liquidity Launcher v1.0.0 deployments. Contains
2426
**ContinuousClearingAuctionFactory**
2527
| Network | Address | Commit Hash | Version |
2628
| -------- | ------------------------------------------ | ---------------------------------------- | ---------------- |
27-
| Mainnet | 0xcca1101C61cF5cb44C968947985300DF945C3565 | 95d7da7a2d25cf60f14eaccd6ab5fb24d393a452 | v1.1.0 |
28-
| Unichain | 0xcca1101C61cF5cb44C968947985300DF945C3565 | 95d7da7a2d25cf60f14eaccd6ab5fb24d393a452 | v1.1.0 |
29-
| Base | 0xcca1101C61cF5cb44C968947985300DF945C3565 | 95d7da7a2d25cf60f14eaccd6ab5fb24d393a452 | v1.1.0 |
30-
| Sepolia | 0xcca1101C61cF5cb44C968947985300DF945C3565 | 95d7da7a2d25cf60f14eaccd6ab5fb24d393a452 | v1.1.0 |
29+
| Mainnet | 0xCCccCcCAE7503Cac057829BF2811De42E16e0bD5 | 87b2546a298f691c095b06ec077ceef25ba56007 | v1.1.0 |
30+
| Unichain | 0xCCccCcCAE7503Cac057829BF2811De42E16e0bD5 | 87b2546a298f691c095b06ec077ceef25ba56007 | v1.1.0 |
31+
| Base | 0xCCccCcCAE7503Cac057829BF2811De42E16e0bD5 | 87b2546a298f691c095b06ec077ceef25ba56007 | v1.1.0 |
32+
| Sepolia | 0xCCccCcCAE7503Cac057829BF2811De42E16e0bD5 | 87b2546a298f691c095b06ec077ceef25ba56007 | v1.1.0 |
3133

3234
## v1.0.0
3335

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Addresses are cannonical across select EVM chains. If it is not already deployed
3535

3636
| Network | Address | Commit Hash | Version |
3737
| -------- | ------------------------------------------ | ---------------------------------------- | ---------------- |
38-
| v1.1.0 | 0xcca1101C61cF5cb44C968947985300DF945C3565 | 95d7da7a2d25cf60f14eaccd6ab5fb24d393a452 | v1.1.0 |
38+
| v1.1.0 | 0xCCccCcCAE7503Cac057829BF2811De42E16e0bD5 | 87b2546a298f691c095b06ec077ceef25ba56007 | v1.1.0 |
3939
| v1.0.0\* | 0x0000ccaDF55C911a2FbC0BB9d2942Aa77c6FAa1D | 154fd189022858707837112943c09346869c964f | v1.0.0-candidate |
4040

4141
> \*v1.0.0-candidate is the initial version of CCA and is NOT recommended for production use. For more details, see the [Changelog](./CHANGELOG.md).

docs/autogen/src/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Addresses are cannonical across select EVM chains. If it is not already deployed
3535

3636
| Network | Address | Commit Hash | Version |
3737
| -------- | ------------------------------------------ | ---------------------------------------- | ---------------- |
38-
| v1.1.0 | 0xcca1101C61cF5cb44C968947985300DF945C3565 | 95d7da7a2d25cf60f14eaccd6ab5fb24d393a452 | v1.1.0 |
38+
| v1.1.0 | 0xCCccCcCAE7503Cac057829BF2811De42E16e0bD5 | | v1.1.0 |
3939
| v1.0.0\* | 0x0000ccaDF55C911a2FbC0BB9d2942Aa77c6FAa1D | 154fd189022858707837112943c09346869c964f | v1.0.0-candidate |
4040

4141
> \*v1.0.0-candidate is the initial version of CCA and is NOT recommended for production use. For more details, see the [Changelog](./CHANGELOG.md).
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
// SPDX-License-Identifier: MIT
2+
pragma solidity ^0.8.26;
3+
4+
import {IValidationHook} from '../src/interfaces/IValidationHook.sol';
5+
import {IBaseERC1155ValidationHook} from '../src/periphery/validationHooks/BaseERC1155ValidationHook.sol';
6+
import {IGatedERC1155ValidationHook} from '../src/periphery/validationHooks/GatedERC1155ValidationHook.sol';
7+
import {IValidationHookIntrospection} from '../src/periphery/validationHooks/ValidationHookIntrospection.sol';
8+
import {IERC165} from '@openzeppelin/contracts/utils/introspection/IERC165.sol';
9+
import {console} from 'forge-std/console.sol';
10+
11+
contract IntrospectionSelectors {
12+
function run() public {
13+
console.log('IERC165');
14+
console.logBytes4(type(IERC165).interfaceId);
15+
console.log('IValidationHook');
16+
console.logBytes4(type(IValidationHook).interfaceId);
17+
console.log('IBaseERC1155ValidationHook');
18+
console.logBytes4(type(IBaseERC1155ValidationHook).interfaceId);
19+
console.log('IGatedERC1155ValidationHook');
20+
console.logBytes4(type(IGatedERC1155ValidationHook).interfaceId);
21+
}
22+
}

script/deploy/DeployContinuousAuctionFactory.s.sol

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import 'forge-std/console2.sol';
88

99
/// @title DeployContinuousAuctionFactoryScript
1010
/// @notice Script to deploy the ContinuousClearingAuctionFactory
11-
/// @dev This will deploy to 0xcca1101C61cF5cb44C968947985300DF945C3565 on most EVM chains
11+
/// @dev This will deploy to 0xCCccCcCAE7503Cac057829BF2811De42E16e0bD5 on most EVM chains
1212
/// with the CREATE2 deployer at 0x4e59b44847b379578588920cA78FbF26c0B4956C
1313
contract DeployContinuousAuctionFactoryScript is Script {
1414
function run() public returns (IContinuousClearingAuctionFactory factory) {
@@ -17,8 +17,8 @@ contract DeployContinuousAuctionFactoryScript is Script {
1717
bytes32 initCodeHash = keccak256(type(ContinuousClearingAuctionFactory).creationCode);
1818
console2.logBytes32(initCodeHash);
1919

20-
// Deploys to: 0xcca1101C61cF5cb44C968947985300DF945C3565
21-
bytes32 salt = 0x3607090e08af583d30437fc9eb4cd2105a732f30be11624f8d145b53167f17f9;
20+
// Deploys to: 0xCCccCcCAE7503Cac057829BF2811De42E16e0bD5
21+
bytes32 salt = 0xf0354626131f1f8f0a1f7a3837aa270bdcfc1a9e5c6f9125a6f69ba45e416ce3;
2222
factory = IContinuousClearingAuctionFactory(address(new ContinuousClearingAuctionFactory{salt: salt}()));
2323

2424
console2.log('ContinuousClearingAuctionFactory deployed to:', address(factory));

snapshots/AuctionTest.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
2-
"Auction bytecode size": "18374",
2+
"Auction bytecode size": "18420",
33
"checkpoint_advanceToCurrentStep": "179349",
44
"checkpoint_noBids": "165321",
55
"checkpoint_zeroSupply": "119208",
66
"claimTokens": "67156",
7-
"exitBid": "84483",
8-
"exitPartiallyFilledBid": "230504",
7+
"exitBid": "84402",
8+
"exitPartiallyFilledBid": "230397",
99
"submitBid": "154252",
1010
"submitBidWithoutPrevTickPrice": "154140",
1111
"submitBidWithoutPrevTickPrice_initializeTick_search": "202179",

0 commit comments

Comments
 (0)