in progress fixing pr comments

Author: lupin408

test/e2e/src/AssertionEngine.ts

@@ -217,54 +217,9 @@ export class AssertionEngine {
   async validateAuctionAssertions(auctionAssertions: AuctionAssertion[]): Promise<void> {
     for (const assertion of auctionAssertions) {
       console.log(LOG_PREFIXES.INFO, "Auction assertion validation");
-
       // Get the current auction state
       const auctionState = await this.getAuctionState();
-      for (const key of Object.keys(assertion)) {
-        if (key === TYPE_FIELD) continue;
-        if (key === "latestCheckpoint") continue;
-        let expected = assertion[key as keyof AuctionAssertion];
-        if (expected != undefined && expected != null) {
-          if (!this.validateEquality(expected, auctionState[key as keyof AuctionState])) {
-            // Check if this is a VariableAmount with variance
-            const variance = typeof expected === "object" && "variation" in expected ? expected.variation : undefined;
-            throw new Error(
-              ERROR_MESSAGES.AUCTION_ASSERTION_FAILED(
-                typeof expected === "object" && "amount" in expected
-                  ? expected.amount
-                  : assertion[key as keyof AuctionAssertion],
-                auctionState[key as keyof AuctionState],
-                key,
-                variance,
-              ),
-            );
-          }
-        }
-      }
-
-      if (assertion.latestCheckpoint) {
-        for (const key of Object.keys(assertion.latestCheckpoint)) {
-          if (key === TYPE_FIELD) continue;
-          let expected = assertion.latestCheckpoint[key as keyof CheckpointStruct];
-          if (expected != undefined && expected != null) {
-            let actual = auctionState.latestCheckpoint[key as keyof CheckpointStruct];
-            if (!this.validateEquality(expected, actual)) {
-              // Check if this is a VariableAmount with variance
-              const variance = typeof expected === "object" && "variation" in expected ? expected.variation : undefined;
-              throw new Error(
-                ERROR_MESSAGES.AUCTION_CHECKPOINT_ASSERTION_FAILED(
-                  typeof expected === "object" && "amount" in expected
-                    ? expected.amount
-                    : assertion.latestCheckpoint[key as keyof CheckpointStruct],
-                  auctionState.latestCheckpoint[key as keyof CheckpointStruct],
-                  key,
-                  variance,
-                ),
-              );
-            }
-          }
-        }
-      }
+      this.validateAuctionAssertion(assertion, auctionState);
       const { type, ...assertionWithoutType } = assertion;
       console.log(
         LOG_PREFIXES.SUCCESS,