Skip to content

Commit 3274a65

Browse files
authored
Merge pull request #129 from Uniswap/fix/zizmor-security-findings
fix: resolve zizmor GitHub Actions security findings
2 parents 6e69f1a + eded1cc commit 3274a65

File tree

6 files changed

+11
-1
lines changed

6 files changed

+11
-1
lines changed

.github/workflows/deploy-tenderly.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,15 @@ on:
77
paths:
88
- src/briefcase/deployers/**
99

10+
permissions: {}
1011
jobs:
1112
deploy-to-tenderly:
1213
runs-on: ubuntu-latest
1314
steps:
1415
- uses: actions/checkout@v4
1516
with:
1617
submodules: recursive
18+
persist-credentials: false
1719

1820
# Create Tenderly Virtual TestNet environment: https://docs.tenderly.co/virtual-testnets
1921
- name: Setup Tenderly Virtual TestNet
@@ -38,6 +40,7 @@ jobs:
3840
env:
3941
TENDERLY_ADMIN_RPC_URL: ${{ env.TENDERLY_ADMIN_RPC_URL }}
4042
ADMIN_WALLET: ${{ vars.TENDERLY_ADMIN_WALLET }}
43+
VARS_TENDERLY_ADMIN_WALLET: ${{ vars.TENDERLY_ADMIN_WALLET }}
4144
run: |
4245
curl $TENDERLY_ADMIN_RPC_URL \
4346
-X POST \
@@ -46,7 +49,7 @@ jobs:
4649
"jsonrpc": "2.0",
4750
"method": "tenderly_setBalance",
4851
"params": [
49-
"${{ vars.TENDERLY_ADMIN_WALLET }}",
52+
"${VARS_TENDERLY_ADMIN_WALLET}",
5053
"0x3635c9adc5dea00000"
5154
],
5255
"id": "1234"

.github/workflows/pre-commit.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,14 @@ on:
55
pull_request:
66
branches: [main, master, staging, dev, feat/**, fix/**]
77

8+
permissions: {}
89
jobs:
910
pre-commit:
1011
runs-on: ubuntu-latest
1112
steps:
1213
- uses: actions/checkout@v3
14+
with:
15+
persist-credentials: false
1316
- uses: actions/setup-python@v2
1417
with:
1518
submodules: recursive

.github/workflows/push-briefcase.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ jobs:
2222
uses: actions/checkout@v4
2323
with:
2424
fetch-depth: 0
25+
persist-credentials: false
2526

2627
- name: Configure Git
2728
run: |

.github/workflows/update-briefcase.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ jobs:
1818
uses: actions/checkout@v4
1919
with:
2020
submodules: recursive
21+
persist-credentials: false
2122

2223
- name: Install Foundry
2324
uses: foundry-rs/foundry-toolchain@v1

.github/workflows/update-submodules.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ jobs:
1616
uses: actions/checkout@v4
1717
with:
1818
fetch-depth: 0
19+
persist-credentials: false
1920

2021
- name: Update Submodules
2122
run: |

.github/workflows/verify-briefcase.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ jobs:
1616
uses: actions/checkout@v4
1717
with:
1818
submodules: recursive
19+
persist-credentials: false
1920

2021
- name: Install Foundry
2122
uses: foundry-rs/foundry-toolchain@v1

0 commit comments

Comments
 (0)