Use external distribution of Juliet test suite (#155)

Use external distribution of Juliet test suite

---------

Co-authored-by: Ivan Volkov <[email protected]>

Author: Lipen

build.gradle.kts

@@ -36,6 +36,7 @@ allprojects {
 
     repositories {
         mavenCentral()
+        maven("https://jitpack.io")
         maven("https://s01.oss.sonatype.org/content/repositories/orgunittestbotsoot-1004/")
         maven("https://plugins.gradle.org/m2")
         maven("https://www.jetbrains.com/intellij-repository/releases")

buildSrc/src/main/kotlin/Dependencies.kt

@@ -15,6 +15,7 @@ object Versions {
     const val jmh = "1.21"
     const val joda_time = "2.12.5"
     const val jooq = "3.14.16"
+    const val juliet = "1.3.2"
     const val junit = "5.9.2"
     const val kotlin = "1.7.21"
     const val kotlin_logging = "1.8.3"
@@ -265,6 +266,20 @@ object Libs {
         name = "asm-util",
         version = Versions.asm
     )
+
+    // https://github.com/UnitTestBot/juliet-java-test-suite
+    val juliet_support = dep(
+        group = "com.github.UnitTestBot.juliet-java-test-suite",
+        name = "support",
+        version = Versions.juliet
+    )
+
+    @Suppress("FunctionName")
+    fun juliet_cwe(cweNum: Int) = dep(
+        group = "com.github.UnitTestBot.juliet-java-test-suite",
+        name = "cwe${cweNum}",
+        version = Versions.juliet
+    )
 }
 
 object Plugins {

jacodb-analysis/build.gradle.kts

@@ -13,8 +13,11 @@ dependencies {
     implementation(Libs.kotlinx_serialization_json)
 
     testImplementation(testFixtures(project(":jacodb-core")))
-    testImplementation(Libs.javax_servlet_api)
-    testImplementation(Libs.joda_time)
-    testImplementation(files("src/test/resources/juliet.jar"))
+    testImplementation(project(":jacodb-api"))
     testImplementation(files("src/test/resources/pointerbench.jar"))
+    testImplementation(Libs.joda_time)
+    testImplementation(Libs.juliet_support)
+    for (cweNum in listOf(89, 476, 563, 690)) {
+        testImplementation(Libs.juliet_cwe(cweNum))
+    }
 }

jacodb-analysis/src/test/kotlin/org/jacodb/analysis/impl/BaseAnalysisTest.kt

@@ -16,7 +16,7 @@
 
 package org.jacodb.analysis.impl
 
-import juliet.testcasesupport.AbstractTestCase
+import juliet.support.AbstractTestCase
 import kotlinx.coroutines.runBlocking
 import org.jacodb.analysis.engine.VulnerabilityInstance
 import org.jacodb.api.JcClassOrInterface

jacodb-analysis/src/test/kotlin/org/jacodb/analysis/impl/SqlInjectionAnalysisTest.kt

@@ -35,7 +35,10 @@ import java.util.stream.Stream
 class SqlInjectionAnalysisTest : BaseAnalysisTest() {
     companion object : WithDB(Usages, InMemoryHierarchy) {
         @JvmStatic
-        fun provideClassesForJuliet89(): Stream<Arguments> = provideClassesForJuliet(89, emptyList())
+        fun provideClassesForJuliet89(): Stream<Arguments> = provideClassesForJuliet(89, listOf(
+            // Not working yet (#156)
+            "s03", "s04"
+        ))
 
         private val vulnerabilityType = SqlInjectionAnalyzer.vulnerabilityDescription.ruleId
     }