Fix: add debug explicitly to ords docker-compose and remove it from .env as it causes trouble with SQLcl

Author: phartenfeller

docker-compose.yml

@@ -32,6 +32,8 @@ services:
     restart: no
     env_file:
       - ./.env
+    environment:
+      - DEBUG=true
     depends_on:
       23ai:
         condition: service_healthy

docs/src/content/docs/migrations/25-3.md

@@ -74,7 +74,6 @@ echo "DBSERVICENAME=\"FREEPDB1\"" >>.env
 echo "DBHOST=\"23ai\"" >>.env
 echo "DBPORT=\"1521\"" >>.env
 echo "FORCE_SECURE=\"false\"" >>.env
-echo "DEBUG=\"true\"" >>.env
 ```
 
 ### Stop the containers
@@ -137,3 +136,14 @@ end;
 docker image ls
 docker image rm {image_name}
 ```
+
+## Hotfix: DEBUG env var
+
+<Aside type="caution">In the first version of this migration I added `DEBUG=TRUE` to the `.env` file.
+
+Please remove this line from your `.env` file if it exists, as it messed up SQLcl scripts.
+</Aside>
+
+(The new SQLcl version also uses this variable to output debug information. As some scripts read the output of SQLcl, it can cause issues.)
+
+If you don't have it in your `.env` file, you can proceed without any changes.

scripts/util/user-exists-in-db.sh

@@ -7,8 +7,9 @@ user_exists_in_db() {
   fi
 
   local USERNAME=$1
-  local count=$(
-    sql -S -name $DB_CONN_NAME <<SQL
+  local count
+  count=$(
+    sql -S -name "$DB_CONN_NAME" <<SQL
 SET HEADING OFF
 SET FEEDBACK OFF
 SET PAGESIZE 0

setup.sh

@@ -24,7 +24,6 @@ echo "DBSERVICENAME=\"FREEPDB1\"" >>.env
 echo "DBHOST=\"23ai\"" >>.env
 echo "DBPORT=\"1521\"" >>.env
 echo "FORCE_SECURE=\"false\"" >>.env
-echo "DEBUG=\"true\"" >>.env
 
 echo "Created .env file"