use invariant string operations where possible

Author: K-Tone

Assets/Editor/AddScenesToBuild.cs

@@ -66,7 +66,7 @@ private static bool IsPathInExcludedFolder(string path)
         // Check if the path or any part of it contains any of the excluded folder names
         foreach (string folder in excludedFolders)
         {
-            if (path.ToLower().Contains(folder.ToLower()))
+            if (path.Contains(folder, StringComparison.InvariantCultureIgnoreCase))
             {
                 return true;
             }

ExternalSampleProjects/InputDeviceTester/Assets/InputDeviceTester/Scripts/Input/GamepadISX.cs

@@ -109,9 +109,9 @@ protected string FirstLetterToUpper(string str)
         if (String.IsNullOrEmpty(str))
             return null;
         else if (str.Length == 1)
-            return str.ToUpper();
+            return str.ToUpperInvariant();
         else
-            return char.ToUpper(str[0]) + str.Substring(1);
+            return char.ToUpperInvariant(str[0]) + str.Substring(1);
     }
 
     protected void ShowMessage(string msg)

ExternalSampleProjects/InputDeviceTester/Assets/InputDeviceTester/Scripts/Input/PenISX.cs

@@ -190,9 +190,9 @@ private string FirstLetterToUpper(string str)
         if (String.IsNullOrEmpty(str))
             return null;
         else if (str.Length == 1)
-            return str.ToUpper();
+            return str.ToUpperInvariant();
         else
-            return char.ToUpper(str[0]) + str.Substring(1);
+            return char.ToUpperInvariant(str[0]) + str.Substring(1);
     }
 
     private void ShowMessage(string msg)

Packages/com.unity.inputsystem/InputSystem/Controls/InputControlLayout.cs

@@ -1673,7 +1673,7 @@ public InputControlLayout ToLayout()
                 // Before render behavior.
                 if (!string.IsNullOrEmpty(beforeRender))
                 {
-                    var beforeRenderLowerCase = beforeRender.ToLower();
+                    var beforeRenderLowerCase = beforeRender.ToLowerInvariant();
                     if (beforeRenderLowerCase == "ignore")
                         layout.m_UpdateBeforeRender = false;
                     else if (beforeRenderLowerCase == "update")
@@ -1685,7 +1685,7 @@ public InputControlLayout ToLayout()
                 // CanRunInBackground flag.
                 if (!string.IsNullOrEmpty(runInBackground))
                 {
-                    var runInBackgroundLowerCase = runInBackground.ToLower();
+                    var runInBackgroundLowerCase = runInBackground.ToLowerInvariant();
                     if (runInBackgroundLowerCase == "enabled")
                         layout.canRunInBackground = true;
                     else if (runInBackgroundLowerCase == "disabled")

Packages/com.unity.inputsystem/InputSystem/Editor/AssetImporter/InputActionImporter.cs

@@ -236,8 +236,8 @@ private static void GenerateWrapperCode(AssetImportContext ctx, InputActionAsset
                 var directory = Path.GetDirectoryName(assetPath);
                 wrapperFilePath = Path.Combine(directory, wrapperFilePath);
             }
-            else if (!wrapperFilePath.ToLower().StartsWith("assets/") &&
-                     !wrapperFilePath.ToLower().StartsWith("assets\\"))
+            else if (!wrapperFilePath.StartsWith("assets/", StringComparison.InvariantCultureIgnoreCase) &&
+                     !wrapperFilePath.StartsWith("assets\\", StringComparison.InvariantCultureIgnoreCase))
             {
                 // User-specified file in Assets/ folder.
                 wrapperFilePath = Path.Combine("Assets", wrapperFilePath);

Packages/com.unity.inputsystem/InputSystem/Editor/InputParameterEditor.cs

@@ -210,7 +210,7 @@ public void Initialize(string label, string tooltip, string defaultName, Func<fl
                 m_GetDefaultValue = getDefaultValue;
                 m_ToggleLabel = EditorGUIUtility.TrTextContent("Default",
                     defaultComesFromInputSettings
-                    ? $"If enabled, the default {label.ToLower()} configured globally in the input settings is used. See Edit >> Project Settings... >> Input (NEW)."
+                    ? $"If enabled, the default {label.ToLowerInvariant()} configured globally in the input settings is used. See Edit >> Project Settings... >> Input (NEW)."
                     : "If enabled, the default value is used.");
                 m_ValueLabel = EditorGUIUtility.TrTextContent(label, tooltip);
                 if (defaultComesFromInputSettings)

Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPluginControl.cs

@@ -73,10 +73,10 @@ public static void RegisterPlatform(BuildTarget target)
         private static bool IsPluginInstalled()
         {
             var registeredPackages = UnityEditor.PackageManager.PackageInfo.GetAllRegisteredPackages();
-            var plugInName = PlugInName + EditorUserBuildSettings.activeBuildTarget.ToString().ToLower();
+            var plugInName = PlugInName + EditorUserBuildSettings.activeBuildTarget.ToString();
             foreach (var package in registeredPackages)
             {
-                if (package.name.Equals(plugInName))
+                if (package.name.Equals(plugInName, StringComparison.InvariantCultureIgnoreCase))
                     return true;
             }
             return false;

Packages/com.unity.inputsystem/InputSystem/Editor/Internal/AdvancedDropdown/AdvancedDropdownDataSource.cs

@@ -80,15 +80,15 @@ protected virtual AdvancedDropdownItem Search(string searchString)
             if (searchTree == null)
             {
                 // Support multiple search words separated by spaces.
-                var searchWords = searchString.ToLower().Split(' ');
+                var searchWords = searchString.ToLowerInvariant().Split(' ');
 
                 // We keep two lists. Matches that matches the start of an item always get first priority.
                 var matchesStart = new List<AdvancedDropdownItem>();
                 var matchesWithin = new List<AdvancedDropdownItem>();
 
                 foreach (var e in m_SearchableElements)
                 {
-                    var name = e.searchableName.ToLower().Replace(" ", "");
+                    var name = e.searchableName.ToLowerInvariant().Replace(" ", "");
                     AddMatchItem(e, name, searchWords, matchesStart, matchesWithin);
                 }
 

Packages/com.unity.inputsystem/InputSystem/Plugins/XR/XRLayoutBuilder.cs

@@ -217,7 +217,7 @@ private InputControlLayout Build()
                 if (inheritedLayout != null)
                     featureName = ConvertPotentialAliasToName(inheritedLayout, featureName);
 
-                featureName = featureName.ToLower();
+                featureName = featureName.ToLowerInvariant();
 
                 if (IsSubControl(featureName))
                 {

Packages/com.unity.inputsystem/InputSystem/Utilities/StringHelpers.cs

@@ -327,7 +327,6 @@ public static string MakeUniqueName<TExisting>(string baseName, IEnumerable<TExi
                 return baseName;
 
             var name = baseName;
-            var nameLowerCase = name.ToLower();
             var nameIsUnique = false;
             var namesTried = 1;
 
@@ -351,10 +350,9 @@ public static string MakeUniqueName<TExisting>(string baseName, IEnumerable<TExi
                 foreach (var existing in existingSet)
                 {
                     var existingName = getNameFunc(existing);
-                    if (existingName.ToLower() == nameLowerCase)
+                    if (existingName.Equals(name, StringComparison.InvariantCultureIgnoreCase))
                     {
                         name = $"{baseName}{namesTried}";
-                        nameLowerCase = name.ToLower();
                         nameIsUnique = false;
                         ++namesTried;
                         break;