Invert clamping of up down values for WebGLGamepad

We were clamping with the wrong values which would make the UI not react to up and down when using Gamepad sticks.

Author: jfreire-unity

Assets/Tests/InputSystem/Plugins/WebGLTests.cs

@@ -43,9 +43,8 @@ public void Devices_SupportsWebGLStandardGamepads()
         Assert.That(gamepad.leftTrigger.ReadUnprocessedValue(), Is.EqualTo(0.123).Within(0.0001));
         Assert.That(gamepad.rightTrigger.ReadUnprocessedValue(), Is.EqualTo(0.234).Within(0.0001));
 
-        AssertStickValues(gamepad.leftStick, new Vector2(0.345f, -0.456f), -0.456f, 0, 0, 0.345f);
-        AssertStickValues(gamepad.rightStick, new Vector2(0.567f, -0.678f), -0.678f, 0, 0, 0.567f);
-
+        AssertStickValues(gamepad.leftStick, new Vector2(0.345f, -0.456f), 0, 0.456f, 0, 0.345f);
+        AssertStickValues(gamepad.rightStick, new Vector2(0.567f, -0.678f), 0, 0.678f, 0, 0.567f);
 
         InputSystem.QueueStateEvent(gamepad, new WebGLGamepadState
         {
@@ -54,9 +53,8 @@ public void Devices_SupportsWebGLStandardGamepads()
         });
         InputSystem.Update();
 
-        AssertStickValues(gamepad.leftStick, new Vector2(-0.345f, 0.456f), 0, -0.456f, 0.345f, 0);
-        AssertStickValues(gamepad.rightStick, new Vector2(-0.567f, 0.678f), 0, -0.678f, 0.567f, 0);
-
+        AssertStickValues(gamepad.leftStick, new Vector2(-0.345f, 0.456f), 0.456f, 0, 0.345f, 0);
+        AssertStickValues(gamepad.rightStick, new Vector2(-0.567f, 0.678f), 0.678f, 0, 0.567f, 0);
 
         // Test all buttons.
         AssertButtonPress(gamepad, new WebGLGamepadState().WithButton(GamepadButton.South), gamepad[GamepadButton.South]);

Packages/com.unity.inputsystem/InputSystem/Plugins/WebGL/WebGLGamepad.cs

@@ -19,11 +19,11 @@ internal unsafe struct WebGLGamepadState : IInputStateTypeInfo
         [InputControl(name = "leftStick", offset = 0)]
         [InputControl(name = "rightStick", offset = 8)]
         [InputControl(name = "leftStick/y", parameters = "invert")]
-        [InputControl(name = "leftStick/up", parameters = "clamp=2,clampMin=0,clampMax=1,invert")]
-        [InputControl(name = "leftStick/down", parameters = "clamp=2,clampMin=-1,clampMax=0,invert=false")]
+        [InputControl(name = "leftStick/up", parameters = "clamp=2,clampMin=-1,clampMax=0,invert")]
+        [InputControl(name = "leftStick/down", parameters = "clamp=2,clampMin=0,clampMax=1,invert=false")]
         [InputControl(name = "rightStick/y", parameters = "invert")]
-        [InputControl(name = "rightStick/up", parameters = "clamp=2,clampMin=0,clampMax=1,invert")]
-        [InputControl(name = "rightStick/down", parameters = "clamp=2,clampMin=-1,clampMax=0,invert=false")]
+        [InputControl(name = "rightStick/up", parameters = "clamp=2,clampMin=-1,clampMax=0,invert")]
+        [InputControl(name = "rightStick/down", parameters = "clamp=2,clampMin=0,clampMax=1,invert=false")]
         // All the buttons we need to bump from single bits to full floats and reset bit offsets.
         [InputControl(name = "buttonSouth", offset = ButtonOffset + 0 * 4, bit = 0, format = "FLT")]
         [InputControl(name = "buttonEast", offset = ButtonOffset + 1 * 4, bit = 0, format = "FLT")]