FIX: ISXB-1306 Fixed a bug within InputActionAsset.cs that prevented actions containing slashes to be found by name. #2160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntaining slashes to be found by name.
Pauliusd01
approved these changes
Apr 4, 2025
Collaborator
Pauliusd01
left a comment
Pauliusd01
left a comment
There was a problem hiding this comment.
LGTM, tried finding actions with 1/multiple slashes, special symbols, non latin characters
ekcoh
changed the title
K-Tone
reviewed
Apr 4, 2025
Packages/com.unity.inputsystem/InputSystem/Actions/InputActionAsset.cs
Outdated
Show resolved
Hide resolved
K-Tone
reviewed
Apr 4, 2025
Packages/com.unity.inputsystem/InputSystem/Actions/InputActionAsset.cs
Outdated
Show resolved
Hide resolved
K-Tone
reviewed
Apr 4, 2025
| }, Is.Not.AllocatingGCMemory()); | ||
| } | ||
|
|
||
| // https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1306 |
Collaborator
There was a problem hiding this comment.
Alternatively, links could be put into a Description attribute:
[Description("See https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1306")]
Collaborator
Author
There was a problem hiding this comment.
This is a fair change to this test since specific to reported use-case
K-Tone
reviewed
Apr 4, 2025
Packages/com.unity.inputsystem/InputSystem/Actions/InputActionAsset.cs
Outdated
Show resolved
Hide resolved
K-Tone
reviewed
Apr 4, 2025
Packages/com.unity.inputsystem/InputSystem/Actions/InputActionAsset.cs
Outdated
Show resolved
Hide resolved
…Asset.cs Co-authored-by: Anthony Yakovlev <[email protected]>
jfreire-unity
approved these changes
Apr 4, 2025
K-Tone
approved these changes
Apr 4, 2025
Collaborator
K-Tone
left a comment
K-Tone
left a comment
There was a problem hiding this comment.
lgtm, thanks for working on the suggestions -- and have a great weekend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggested fix for https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1306. Essentially we had a bug preventing actions with names containing a "/" to be found by name since logic couldn't handle both map syntax and this case.
Testing status & QA
Added unit tests that cover the specified behavior (see diff).
Overall Product Risks
Comments to reviewers
Repro case on ticket should be sufficient as a check for manual testing (Also covered by automated existing and new tests) so I believe chance of regression is minimal. Good to look for potential mistakes with names vs path-syntax I might have overlooked.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: