Skip to content

Conversation

@K-Tone
Copy link
Collaborator

@K-Tone K-Tone commented Apr 3, 2025

Description

While working on another case I noticed that sometimes our automation would fail if it happens to pick up a Unity beta version that hasn't yet finished being built apparently. To fix that, I was suggested to add a --wait flag everywhere 6.2 is used. That's precisely what happens here.

Testing status & QA

This only affects automations.

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@K-Tone K-Tone changed the title make sure to wait for 6000.2 while trying to download it (an instabil… FIX: Fix an instability that occurs when building for 6000.2 if the automation happened to pick up a build that's not yet finished building Apr 3, 2025
@K-Tone K-Tone changed the title FIX: Fix an instability that occurs when building for 6000.2 if the automation happened to pick up a build that's not yet finished building FIX: Fix a 6000.2 build automation instability Apr 3, 2025
@ekcoh
Copy link
Collaborator

ekcoh commented Apr 3, 2025

Thanks for looking into this @K-Tone !

@K-Tone K-Tone force-pushed the anthony/fixup-6000.2-builds branch from 96a5e99 to f6d9f6c Compare April 7, 2025 07:18
@K-Tone K-Tone marked this pull request as ready for review April 7, 2025 07:18
@ekcoh ekcoh requested a review from Pauliusd01 April 7, 2025 13:01
@K-Tone K-Tone requested a review from windxu88 April 7, 2025 13:50
Copy link
Collaborator

@windxu88 windxu88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@K-Tone K-Tone force-pushed the anthony/fixup-6000.2-builds branch from f6d9f6c to 359f19e Compare April 9, 2025 08:49
@K-Tone K-Tone merged commit 3a6f538 into develop Apr 9, 2025
110 checks passed
@K-Tone K-Tone deleted the anthony/fixup-6000.2-builds branch April 9, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants