Skip to content

Conversation

@Sam-Unity
Copy link
Collaborator

Description

These are necessary changes made to images and their alt-text to comply with our accessibility legal requirements.

Testing status & QA

NA

Overall Product Risks

These are purely image and table changes made to docs and zero risk.

Comments to reviewers

Removal of redundant images is also part of the accessibility policy, which is why some were removed as text already contained the info.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@unity-cla-assistant
Copy link

unity-cla-assistant commented May 20, 2025

CLA assistant check
All committers have signed the CLA.

@codecov-github-com
Copy link

codecov-github-com bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2185      +/-   ##
===========================================
- Coverage    65.45%   65.44%   -0.01%     
===========================================
  Files          367      367              
  Lines        53505    53505              
===========================================
- Hits         35024    35019       -5     
- Misses       18481    18486       +5     
Flag Coverage Δ
linux_2021.3_project 70.41% <ø> (ø)
linux_2022.3_project 65.27% <ø> (ø)
linux_6000.0_project 65.35% <ø> (ø)
linux_6000.1_project 65.34% <ø> (ø)
linux_trunk_project 65.34% <ø> (-0.01%) ⬇️
mac_2021.3_pkg 5.41% <ø> (ø)
mac_2021.3_project 70.42% <ø> (ø)
mac_2022.3_pkg 5.19% <ø> (ø)
mac_2022.3_project 65.29% <ø> (ø)
mac_6000.0_pkg 5.20% <ø> (ø)
mac_6000.0_project 65.37% <ø> (-0.01%) ⬇️
mac_6000.1_pkg 5.20% <ø> (ø)
mac_6000.1_project 65.37% <ø> (ø)
mac_trunk_pkg 5.20% <ø> (ø)
mac_trunk_project 65.36% <ø> (ø)
win_2021.3_pkg 5.42% <ø> (ø)
win_2021.3_project 70.49% <ø> (ø)
win_2022.3_pkg 5.20% <ø> (ø)
win_2022.3_project 65.37% <ø> (ø)
win_6000.0_pkg 5.20% <ø> (ø)
win_6000.0_project 65.44% <ø> (ø)
win_6000.1_pkg 5.20% <ø> (ø)
win_6000.1_project 65.45% <ø> (ø)
win_trunk_pkg 5.20% <ø> (ø)
win_trunk_project 65.44% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pauliusd01 Pauliusd01 requested review from Pauliusd01 and ekcoh May 20, 2025 10:31
@stefanunity stefanunity changed the title DOCS accessibility update DOCS: accessibility update May 20, 2025

Once you have created and assigned project-wide actions, the Input System Package page in Project Settings displays the **Actions Editor** interface. Read more about how to use the [Actions Editor](ActionsEditor.md) to configure your actions.

![image alt text](./Images/ProjectSettingsInputActionsSimpleShot.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand on why this has to be removed? It provides the reader with the expectation of what is described.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For UI images, documentation is moving away from providing screenshots of the UI if the information is provided in-text to lower upkeep needed to keep images updated with UI changes. In this case, the text itself leads to the UI reference page for the ActionsEditor, so users who want to know more would be going to that page and see a fully labelled version of the same image in greater detail, so it makes this screenshot slightly redundant.


You can also delete all action maps, or reset all the actions back to the default values from the **more** (⋮) menu at the top right of the Input Actions section of the settings window, below the Project Settings window search field.

![The Input Actions **more** menu as displayed in the Project Settings window](images/InputActionsSettingsMoreMenu.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here.

Copy link
Collaborator Author

@Sam-Unity Sam-Unity May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, for the majority of the screenshot doesn't provide relevant information that we want users to focus on, as the main thing is the highlighted location of the 'more' menu in red. But the location and icon is already described in the text.

In this case, alt-text provided in the image caption would become a repeat of what has already been said above by the adjacent/accompanying text, so the image is decorative.

However if you feel the image is still important, it can be restored and we'll leave the alt-text blank.

@Sam-Unity Sam-Unity requested a review from jfreire-unity May 22, 2025 08:50
Copy link
Collaborator

@jfreire-unity jfreire-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you!

Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just wondering if we shouldn't highlight the change in the CHANGELOG.md? Its non-functional, but still a relevant update/fix.

Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text seems fine to me but I still see some CI failures, reran them

@Pauliusd01
Copy link
Collaborator

Still see valid sounding failures for example:

playmode Test Failure: APIVerificationTests.API_DocumentationManualDoesNotHaveMissingOrUnusedImages

Images directory contains image files that are not referenced in any docs. Consider removing them:
 Workflow-Actions.png
 Workflow-Direct.png
 Workflow-PlayerInput.png

@jfreire-unity jfreire-unity changed the title DOCS: accessibility update DOCS: Accessibility update to comply with our accessibility legal requirements. May 27, 2025
@jfreire-unity jfreire-unity merged commit f42eb5e into develop May 27, 2025
110 of 113 checks passed
@jfreire-unity jfreire-unity deleted the docs-accessibility-update branch May 27, 2025 07:55
unitALG added a commit that referenced this pull request Sep 16, 2025
- Restored removed images (see #2185)
- Added the image references back to the table on the Workflows landing page
- Also replaced makeshift Notes and Tips with DocFx admonitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants