fix: Block websocket use in dedicated server builds

Author: EmandM

com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs

@@ -1668,6 +1668,21 @@ public void CreateDriver(UnityTransport transport, out NetworkDriver driver,
             }
 #endif
 
+#if UNITY_SERVER
+            if (m_ProtocolType == ProtocolType.RelayUnityTransport)
+            {
+                if (m_UseWebSockets)
+                {
+                    Debug.LogError("Transport is configured to use Websockets, but websockets are not available on server builds. Ensure that the \"Use WebSockets\" checkbox is checked under \"Unity Transport\" component.");
+                }
+
+                if (m_RelayServerData.IsWebSocket != 0)
+                {
+                    Debug.LogError("Relay server data indicates usage of WebSockets, but websockets are not available on server builds. Be sure to use \"dtls\" or \"udp\" as the connection type when creating the server data");
+                }
+            }
+#endif
+
 #if UTP_TRANSPORT_2_0_ABOVE
             if (m_UseEncryption)
             {
@@ -1713,32 +1728,30 @@ public void CreateDriver(UnityTransport transport, out NetworkDriver driver,
 #endif
 
 #if UTP_TRANSPORT_2_1_ABOVE
-            if (m_ProtocolType == ProtocolType.RelayUnityTransport)
+            if (m_UseWebSockets && m_RelayServerData.IsWebSocket == 0)
             {
-                if (m_UseWebSockets && m_RelayServerData.IsWebSocket == 0)
-                {
-                    Debug.LogError("Transport is configured to use WebSockets, but Relay server data isn't. Be sure to use \"wss\" as the connection type when creating the server data (instead of \"dtls\" or \"udp\").");
-                }
+                Debug.LogError("Transport is configured to use WebSockets, but Relay server data isn't. Be sure to use \"wss\" as the connection type when creating the server data (instead of \"dtls\" or \"udp\").");
+            }
 
-                if (!m_UseWebSockets && m_RelayServerData.IsWebSocket != 0)
-                {
-                    Debug.LogError("Relay server data indicates usage of WebSockets, but \"Use WebSockets\" checkbox isn't checked under \"Unity Transport\" component.");
-                }
+            if (!m_UseWebSockets && m_RelayServerData.IsWebSocket != 0)
+            {
+                Debug.LogError("Relay server data indicates usage of WebSockets, but \"Use WebSockets\" checkbox isn't checked under \"Unity Transport\" component.");
             }
+        }
 #endif
 
 #if UTP_TRANSPORT_2_0_ABOVE
             if (m_UseWebSockets)
             {
-                driver = NetworkDriver.Create(new WebSocketNetworkInterface(), m_NetworkSettings);
+                driver = NetworkDriver.Create(private new WebSocketNetworkInterface(), m_NetworkSettings);
             }
             else
             {
 #if UNITY_WEBGL && !UNITY_EDITOR
                 Debug.LogWarning($"WebSockets were used even though they're not selected in NetworkManager. You should check {nameof(UseWebSockets)}', on the Unity Transport component, to silence this warning.");
                 driver = NetworkDriver.Create(new WebSocketNetworkInterface(), m_NetworkSettings);
 #else
-                driver = NetworkDriver.Create(new UDPNetworkInterface(), m_NetworkSettings);
+                driver = NetworkDriver.Create(private new UDPNetworkInterface(), m_NetworkSettings);
 #endif
             }
 #else
@@ -1755,10 +1768,10 @@ public void CreateDriver(UnityTransport transport, out NetworkDriver driver,
                 out unreliableSequencedFragmentedPipeline,
                 out reliableSequencedPipeline);
 #else
-            SetupPipelinesForUtp2(driver,
-                out unreliableFragmentedPipeline,
-                out unreliableSequencedFragmentedPipeline,
-                out reliableSequencedPipeline);
+SetupPipelinesForUtp2(driver,
+    out unreliableFragmentedPipeline,
+    out unreliableSequencedFragmentedPipeline,
+    out reliableSequencedPipeline);
 #endif
         }
 
@@ -1826,74 +1839,74 @@ private void SetupPipelinesForUtp2(NetworkDriver driver,
             out NetworkPipeline unreliableFragmentedPipeline,
             out NetworkPipeline unreliableSequencedFragmentedPipeline,
             out NetworkPipeline reliableSequencedPipeline)
-        {
+{
 
-            unreliableFragmentedPipeline = driver.CreatePipeline(
-                typeof(FragmentationPipelineStage)
+    unreliableFragmentedPipeline = driver.CreatePipeline(
+        typeof(FragmentationPipelineStage)
 #if UNITY_MP_TOOLS_NETSIM_IMPLEMENTATION_ENABLED
-                , typeof(SimulatorPipelineStage)
+        , typeof(SimulatorPipelineStage)
 #endif
 #if MULTIPLAYER_TOOLS_1_0_0_PRE_7
                 , typeof(NetworkMetricsPipelineStage)
 #endif
-            );
+    );
 
-            unreliableSequencedFragmentedPipeline = driver.CreatePipeline(
-                typeof(FragmentationPipelineStage),
-                typeof(UnreliableSequencedPipelineStage)
+    unreliableSequencedFragmentedPipeline = driver.CreatePipeline(
+        typeof(FragmentationPipelineStage),
+        typeof(UnreliableSequencedPipelineStage)
 #if UNITY_MP_TOOLS_NETSIM_IMPLEMENTATION_ENABLED
-                , typeof(SimulatorPipelineStage)
+        , typeof(SimulatorPipelineStage)
 #endif
 #if MULTIPLAYER_TOOLS_1_0_0_PRE_7
                 , typeof(NetworkMetricsPipelineStage)
 #endif
-            );
+    );
 
-            reliableSequencedPipeline = driver.CreatePipeline(
-                typeof(ReliableSequencedPipelineStage)
+    reliableSequencedPipeline = driver.CreatePipeline(
+        typeof(ReliableSequencedPipelineStage)
 #if UNITY_MP_TOOLS_NETSIM_IMPLEMENTATION_ENABLED
-                , typeof(SimulatorPipelineStage)
+        , typeof(SimulatorPipelineStage)
 #endif
 #if MULTIPLAYER_TOOLS_1_0_0_PRE_7
                 , typeof(NetworkMetricsPipelineStage)
 #endif
-            );
-        }
+    );
+}
 #endif
-        // -------------- Utility Types -------------------------------------------------------------------------------
+// -------------- Utility Types -------------------------------------------------------------------------------
 
 
-        /// <summary>
-        /// Cached information about reliability mode with a certain client
-        /// </summary>
-        private struct SendTarget : IEquatable<SendTarget>
-        {
-            public readonly ulong ClientId;
-            public readonly NetworkPipeline NetworkPipeline;
+/// <summary>
+/// Cached information about reliability mode with a certain client
+/// </summary>
+private struct SendTarget : IEquatable<SendTarget>
+{
+    public readonly ulong ClientId;
+    public readonly NetworkPipeline NetworkPipeline;
 
-            public SendTarget(ulong clientId, NetworkPipeline networkPipeline)
-            {
-                ClientId = clientId;
-                NetworkPipeline = networkPipeline;
-            }
+    public SendTarget(ulong clientId, NetworkPipeline networkPipeline)
+    {
+        ClientId = clientId;
+        NetworkPipeline = networkPipeline;
+    }
 
-            public bool Equals(SendTarget other)
-            {
-                return ClientId == other.ClientId && NetworkPipeline.Equals(other.NetworkPipeline);
-            }
+    public bool Equals(SendTarget other)
+    {
+        return ClientId == other.ClientId && NetworkPipeline.Equals(other.NetworkPipeline);
+    }
 
-            public override bool Equals(object obj)
-            {
-                return obj is SendTarget other && Equals(other);
-            }
+    public override bool Equals(object obj)
+    {
+        return obj is SendTarget other && Equals(other);
+    }
 
-            public override int GetHashCode()
-            {
-                unchecked
-                {
-                    return (ClientId.GetHashCode() * 397) ^ NetworkPipeline.GetHashCode();
-                }
-            }
+    public override int GetHashCode()
+    {
+        unchecked
+        {
+            return (ClientId.GetHashCode() * 397) ^ NetworkPipeline.GetHashCode();
         }
     }
+}
+    }
 }