Skip to content

feat: add networkmanager topology analytics [MTT-9974] #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 14, 2025
Merged

feat: add networkmanager topology analytics [MTT-9974] #3309

merged 16 commits into from
Mar 14, 2025

Conversation

@NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Feb 20, 2025 •
edited
Loading

This PR creates a small footprint NetworkManager configuration usage analytics pass when running from within the Unity editor. It includes some additional modifications and organization to make any future analytics easier to add and write integration tests for.

MTT-9974

Changelog

NA

Testing and Documentation

  • Includes the AnalyticsTests integration test.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
update
9804c9b 
Adding NetworkManagerAnalytics struct
@NoelStephensUnity
update
a17194f 
Adding analytics information gathering scripts to handle tracking the network configurations for each session while in play mode. Upon exiting play mode,  analytics data can be submitted.
The actual submission is yet to be implemented.
@NoelStephensUnity
update
063e5c8 
Finalizing the first round pass of gathering analytics.
@NoelStephensUnity
update
0edb4d6 
Removing the erroneous NetworkMessageMetrics  when MULTIPLAYER_TOOLS was not defined from NetworkConfig.
Remove unused namespace and minor clean up.
@NoelStephensUnity
Merge branch 'develop-2.0.0' into feat/add-networkmanager-topology-an…
6e025aa 
…alytics-MTT-9974
@NoelStephensUnity
Merge branch 'develop-2.0.0' into feat/add-networkmanager-topology-an…
fac8ae1 
…alytics-MTT-9974
@NoelStephensUnity
update
27a91af 
Adjusting to final first pass analytics data being gathered.
@NoelStephensUnity
style
2287c05 
Removing white spaces.
Excluding the LogAnalytics method unless ENABLE_NGO_ANALYTICS_LOGGING is defined.
@NoelStephensUnity
update
92a6385 
Minor adjustments for when ENABLE_NGO_ANALYTICS_LOGGING is defined.
@NoelStephensUnity
Merge branch 'develop-2.0.0' into feat/add-networkmanager-topology-an…
7a13eff 
…alytics-MTT-9974
@NoelStephensUnity
update
97fc86d 
Refactored this a bit so we don't have a lot of the Analytics stuff within the NetworkManager, making some adjustments for integration testing and future analytics needs, and making sure we are not adding to our public API footprint.
@NoelStephensUnity
test
6446754 
Adding the integration test to validate the analytics data collection flow/process.
Adding the ability to make adjustments during integration testing from assemblies outside  of the TestHelper runtime scope.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review March 11, 2025 20:44
@NoelStephensUnity
update
ac9cb1a 
moving the NetworkSessionInfo struct into the NetcodeAnalytics file.
@NoelStephensUnity
test - fix
635688f 
I think integration tests failed on the first pass because EditorAnalytics.enabled is defaulted to false during CI.
This update should resolve the issue if that is the case.
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) March 14, 2025 03:28
@NoelStephensUnity NoelStephensUnity merged commit fae6b2f into develop-2.0.0 Mar 14, 2025
27 checks passed
@NoelStephensUnity NoelStephensUnity deleted the feat/add-networkmanager-topology-analytics-MTT-9974 branch March 14, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmandM EmandM EmandM approved these changes

@miniwolf miniwolf Awaiting requested review from miniwolf

@fluong6 fluong6 Awaiting requested review from fluong6

@michalChrobot michalChrobot Awaiting requested review from michalChrobot

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NoelStephensUnity @EmandM @netcode-ci-service