Skip to content

ci: [NGOv1.X] Fixing WhenAnticipating_ValueChangesImmediately test #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 13, 2025
Merged

ci: [NGOv1.X] Fixing WhenAnticipating_ValueChangesImmediately test #3330

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c3f63eb
Reenabled WhenAnticipating_ValueChangesImmediately test
michalChrobot Mar 3, 2025
f98965b
Reenabled NetworkVariableTests
michalChrobot Mar 3, 2025
718728d
Reenabled RpcTypeSerializationTests and TimeInitializationTests
michalChrobot Mar 3, 2025
50e4702
Revert "Reenabled NetworkVariableTests"
michalChrobot Mar 12, 2025
f84ae99
Revert "Reenabled RpcTypeSerializationTests and TimeInitializationTests"
michalChrobot Mar 12, 2025
7c1e092
Modified WhenAnticipating_ValueChangesImmediately test
michalChrobot Mar 12, 2025
9ee7ab6
Merge branch 'develop' into fixing-test-issues-develop
michalChrobot Mar 12, 2025
a62099d
Corrected library
michalChrobot Mar 12, 2025
18afbd2
Merge branch 'fixing-test-issues-develop' of https://github.com/Unity…
michalChrobot Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransformAnticipationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using Unity.Netcode.Components;
using Unity.Netcode.TestHelpers.Runtime;
using UnityEngine;
using UnityEngine.TestTools;
using UnityEngine.TestTools.Utils;
using Object = UnityEngine.Object;

namespace Unity.Netcode.RuntimeTests
Expand Down Expand Up @@ -115,23 +115,22 @@ public AnticipatedNetworkTransform GetOtherClientComponent()
}

[Test]
[UnityPlatform(exclude = new[] { RuntimePlatform.Android })] // Tracked in MTT-11361
public void WhenAnticipating_ValueChangesImmediately()
{
var testComponent = GetTestComponent();
var quaternionComparer = new QuaternionEqualityComparer(0.000001f);

testComponent.AnticipateMove(new Vector3(0, 1, 2));
testComponent.AnticipateScale(new Vector3(1, 2, 3));
testComponent.AnticipateRotate(Quaternion.LookRotation(new Vector3(2, 3, 4)));

Assert.AreEqual(new Vector3(0, 1, 2), testComponent.transform.position);
Assert.AreEqual(new Vector3(1, 2, 3), testComponent.transform.localScale);
Assert.AreEqual(Quaternion.LookRotation(new Vector3(2, 3, 4)), testComponent.transform.rotation);
Assert.That(testComponent.transform.rotation, Is.EqualTo(Quaternion.LookRotation(new Vector3(2, 3, 4))).Using(quaternionComparer)); // Quaternion comparer added due to FP precision problems on Android devices.

Assert.AreEqual(new Vector3(0, 1, 2), testComponent.AnticipatedState.Position);
Assert.AreEqual(new Vector3(1, 2, 3), testComponent.AnticipatedState.Scale);
Assert.AreEqual(Quaternion.LookRotation(new Vector3(2, 3, 4)), testComponent.AnticipatedState.Rotation);

Assert.That(testComponent.AnticipatedState.Rotation, Is.EqualTo(Quaternion.LookRotation(new Vector3(2, 3, 4))).Using(quaternionComparer)); // Quaternion comparer added due to FP precision problems on Android devices.
}

[Test]
Expand Down