Rename to convert functions to JaggedList

Author: bertt

src/SharpGLTF.Ext.3DTiles/Memory/BinaryTable.cs

@@ -14,12 +14,12 @@ namespace SharpGLTF.Memory
     /// </summary>
     public static class BinaryTable
     {
-        public static List<byte> GetBytesForArray<T>(List<List<T>> values)
+        public static List<byte> ConvertJaggedListToBytes<T>(List<List<T>> values)
         {
             var type = typeof(T);
             if(type == typeof(bool))
             {
-                var booleanBytes = GetBytesBooleans(values.Cast<List<bool>>().ToList());
+                var booleanBytes = ConvertJaggedListOfBooleansToBytes(values.Cast<List<bool>>().ToList());
                 return booleanBytes;
             }
             var bytes = new List<byte>();
@@ -86,7 +86,7 @@ public static byte[] GetBytes<T>(IReadOnlyList<T> values)
             }
         }
 
-        private static List<byte> GetBytesBooleans(List<List<bool>> values)
+        private static List<byte> ConvertJaggedListOfBooleansToBytes(List<List<bool>> values)
         {
             var bits = new BitArray(values.SelectMany(x => x).ToArray());
             var boolBytes = new byte[(bits.Length - 1) / 8 + 1];

src/SharpGLTF.Ext.3DTiles/Schema2/Ext.StructuralMetadataRoot.cs

@@ -874,7 +874,7 @@ private static int GetBufferView<T>(ModelRoot model, IReadOnlyList<T> values)
 
             private static int GetBufferView<T>(ModelRoot model, List<List<T>> values)
             {
-                List<byte> bytes = BinaryTable.GetBytesForArray(values);
+                List<byte> bytes = BinaryTable.ConvertJaggedListToBytes(values);
                 var bufferView = model.UseBufferView(bytes.ToArray());
                 int logicalIndex = bufferView.LogicalIndex;
                 return logicalIndex;

tests/SharpGLTF.Ext.3DTiles.Tests/Memory/BinaryTableTests.cs

@@ -8,12 +8,12 @@ namespace SharpGLTF.Memory
     public class BinaryTableTests
     {
         [Test]
-        public void ConvertListofListofBoolsToBytes()
+        public void ConvertJaggedListOfBoolsToBytes()
         {
             var values = new List<List<bool>>();
             values.Add(new List<bool>() { true, false });
             values.Add(new List<bool>() { false, true });
-            var bytes = BinaryTable.GetBytesForArray(values);
+            var bytes = BinaryTable.ConvertJaggedListToBytes(values);
             // Check size, should be 1 byte for 4 bits
             Assert.That(bytes.Count, Is.EqualTo(1));
 
@@ -31,7 +31,7 @@ public void ConvertListofListofIntToBytes()
             var values = new List<List<int>>();
             values.Add(new List<int>() { 0, 1 });
             values.Add(new List<int>() { 2, 3 });
-            var bytes = BinaryTable.GetBytesForArray(values);
+            var bytes = BinaryTable.ConvertJaggedListToBytes(values);
             Assert.That(bytes.Count, Is.EqualTo(BinaryTable.GetSize<int>() * 4));
         }