Fixed normal renormalization being triggered unnecesarily, reported at vpenades#243

vpenades · vpenades · commit c10acd10727d · 2024-07-25T22:15:11.000+02:00
diff --git a/src/SharpGLTF.Toolkit/Geometry/VertexTypes/VertexPreprocessorLambdas.cs b/src/SharpGLTF.Toolkit/Geometry/VertexTypes/VertexPreprocessorLambdas.cs
@@ -161,7 +161,7 @@ static class VertexPreprocessorLambdas
                 if (n == Vector3.Zero) return null;
 
                 var l = n.Length();
-                if (l < 0.99f || l > 0.01f) vertex.SetNormal(Vector3.Normalize(n));
+                if (Math.Abs(l-1) > 0.01f) vertex.SetNormal(Vector3.Normalize(n));
             }
 
             if (vertex.TryGetTangent(out Vector4 tw))
@@ -175,7 +175,7 @@ static class VertexPreprocessorLambdas
                 if (tw.W < 0) tw.W = -1;
 
                 var l = t.Length();
-                if (l < 0.99f || l > 0.01f) t = Vector3.Normalize(t);
+                if (Math.Abs(l - 1) > 0.01f) t = Vector3.Normalize(t);
 
                 vertex.SetTangent(new Vector4(t, tw.W));
             }

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ static class VertexPreprocessorLambdas`
`161`	`161`	`if (n == Vector3.Zero) return null;`
`162`	`162`
`163`	`163`	`var l = n.Length();`
`164`		`- if (l < 0.99f \|\| l > 0.01f) vertex.SetNormal(Vector3.Normalize(n));`
	`164`	`+ if (Math.Abs(l-1) > 0.01f) vertex.SetNormal(Vector3.Normalize(n));`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`if (vertex.TryGetTangent(out Vector4 tw))`
`@@ -175,7 +175,7 @@ static class VertexPreprocessorLambdas`
`175`	`175`	`if (tw.W < 0) tw.W = -1;`
`176`	`176`
`177`	`177`	`var l = t.Length();`
`178`		`- if (l < 0.99f \|\| l > 0.01f) t = Vector3.Normalize(t);`
	`178`	`+ if (Math.Abs(l - 1) > 0.01f) t = Vector3.Normalize(t);`
`179`	`179`
`180`	`180`	`vertex.SetTangent(new Vector4(t, tw.W));`
`181`	`181`	`}`