add comment

simonLeary42 · simonLeary42 · commit 7d7653c61cdf · 2025-08-27T17:17:52.000-04:00
diff --git a/resources/lib/UnityLDAP.php b/resources/lib/UnityLDAP.php
@@ -177,6 +177,7 @@ private function isIDNumberForbidden($id)
 
     private function getNextIDNumber($start, $IDNumsInUse)
     {
+        // custom ID mappings are considered both UIDs and GIDs
         $IDNumsInUse = array_merge($IDNumsInUse, array_values($this->getCustomIDMappings()));
         $new_id = $start;
         while ($this->isIDNumberForbidden($new_id) || in_array($new_id, $IDNumsInUse)) {

Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,7 @@ private function isIDNumberForbidden($id)`
`177`	`177`
`178`	`178`	`private function getNextIDNumber($start, $IDNumsInUse)`
`179`	`179`	`{`
	`180`	`+ // custom ID mappings are considered both UIDs and GIDs`
`180`	`181`	`$IDNumsInUse = array_merge($IDNumsInUse, array_values($this->getCustomIDMappings()));`
`181`	`182`	`$new_id = $start;`
`182`	`183`	`while ($this->isIDNumberForbidden($new_id) \|\| in_array($new_id, $IDNumsInUse)) {`