phpstan level 8 (#559)

Author: simonLeary42

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-  level: 7
+  level: 8
   paths:
     - resources
     - webroot
@@ -19,6 +19,8 @@ parameters:
         - '#array\|bool supplied for foreach, only iterables are supported#'
         - '#Cannot access offset \S+ on \S+\|bool#'
         - '#ldap_get_entries expects LDAP\\Result, array\|LDAP\\Result given#'
+        - '#array_key_exists expects array, array\|null given#'
+        - '#array\|null supplied for foreach, only iterables are supported#'
       paths:
         - resources/lib/phpopenldaper
     - messages:

resources/lib/UnityHTTPD.php

@@ -243,7 +243,9 @@ public static function getPostData(string $key): string
         return $_POST[$key];
     }
 
-    /* returns null if not found and not $die_if_not_found */
+    /**
+     * @return ($die_if_not_found is true ? string : string|null)
+     */
     public static function getQueryParameter(string $key, bool $die_if_not_found = true): ?string
     {
         if (!array_key_exists($key, $_GET)) {

resources/lib/UnityLDAP.php

@@ -2,6 +2,7 @@
 
 namespace UnityWebPortal\lib;
 
+use RuntimeException;
 use UnityWebPortal\lib\exceptions\EntryNotFoundException;
 use PHPOpenLDAPer\LDAPConn;
 use PHPOpenLDAPer\LDAPEntry;
@@ -147,6 +148,9 @@ private function getCustomIDMappings(): array
         }
         $output_map = [];
         foreach ($output as [$uid, $uidNumber_str]) {
+            if ($uidNumber_str === null) {
+                throw new RuntimeException("uidNumber_str is null");
+            }
             $output_map[$uid] = digits2int($uidNumber_str);
         }
         return $output_map;

test/functional/PIRemoveUserTest.php

@@ -58,6 +58,7 @@ public function testRemoveUser($methodName)
                 break;
             }
         }
+        assert($memberToDelete !== null);
         $this->assertNotEquals($pi->uid, $memberToDelete->uid);
         $this->assertTrue($memberToDelete->getFlag(UserFlag::QUALIFIED));
         $this->assertTrue($piGroup->memberUIDExists($memberToDelete->uid));

test/phpunit-bootstrap.php

@@ -558,6 +558,7 @@ function switchUser(
 
     function switchBackUser(bool $validate = false)
     {
+        assert($this->last_user_nickname !== null);
         $this->switchUser($this->last_user_nickname, validate: $validate);
     }