Skip to content

Commit 6faf44b

Browse files
committed
Make changes to del statement in conftest __del__() method of database connection
1 parent 5748955 commit 6faf44b

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

src/database/database_connection.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,8 @@ def disconnect(self) -> None:
3636
if self.connection is not None:
3737
self.connection.close()
3838
self.connection = None
39-
40-
def __del__(self) -> None:
41-
"""Ensure the connection is closed when the object is deleted."""
42-
self.disconnect()
43-
if os.getenv("RUN_ENV") != "TEST":
44-
print(f"Disconnected from {self.db_url}")
39+
if os.getenv("RUN_ENV") != "TEST":
40+
print(f"Disconnected from {self.db_url}")
4541

4642
def is_connected(self) -> bool:
4743
"""

tests/conftest.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,9 @@ def preprocess_mock_data(
8484
return mem_db.fetch_query(query=query)
8585
except Exception as e:
8686
raise Exception("Exception at helper_filter_irrelevant_records") from e
87+
finally:
88+
if mem_db is not None:
89+
mem_db.disconnect()
8790

8891

8992
# Get path to the temporary mock database file
@@ -114,4 +117,3 @@ def mock_data_frame(mock_data_path: str) -> Generator[pd.DataFrame]:
114117
finally:
115118
if mem_db is not None:
116119
mem_db.disconnect()
117-
del mem_db

0 commit comments

Comments
 (0)