@@ -15,6 +15,7 @@ class Eigen(CMakePackage, ROCmPackage):
1515 homepage = "https://eigen.tuxfamily.org/"
1616 git = "https://gitlab.com/libeigen/eigen.git"
1717 url = "https://gitlab.com/libeigen/eigen/-/archive/3.4.0/eigen-3.4.0.tar.gz"
18+
1819 maintainers ("HaoZeke" )
1920
2021 license ("MPL-2.0" )
@@ -39,9 +40,12 @@ class Eigen(CMakePackage, ROCmPackage):
3940 version ("3.2.5" , sha256 = "8068bd528a2ff3885eb55225c27237cf5cda834355599f05c2c85345db8338b4" )
4041
4142 variant ("nightly" , description = "run Nightly test" , default = False )
42- depends_on ("c" , type = "build" ) # generated
43- depends_on ("cxx" , type = "build" ) # generated
44- depends_on ("fortran" , type = "build" ) # generated
43+
44+ depends_on ("c" , type = "build" )
45+ depends_on ("cxx" , type = "build" )
46+
47+ # TODO: https://eigen.tuxfamily.org/dox/TopicUsingBlasLapack.html
48+
4549 # Older eigen releases haven't been tested with ROCm
4650 conflicts ("+rocm @:3.4.0" )
4751
@@ -85,13 +89,20 @@ def cmake_args(self):
8589 if self .spec .satisfies ("@:3.4" ):
8690 # CMake fails without this flag
8791 # https://gitlab.com/libeigen/eigen/-/issues/1656
88- args += [self .define ("BUILD_TESTING" , "ON" )]
92+ args .extend ([self .define ("BUILD_TESTING" , "ON" )])
93+
8994 if self .spec .satisfies ("+rocm" ):
90- args .append (self .define ("ROCM_PATH" , self .spec ["hip" ].prefix ))
91- args .append (self .define ("HIP_PATH" , self .spec ["hip" ].prefix ))
92- args .append (self .define ("EIGEN_TEST_HIP" , "ON" ))
95+ args .extend (
96+ [
97+ self .define ("ROCM_PATH" , self .spec ["hip" ].prefix ),
98+ self .define ("HIP_PATH" , self .spec ["hip" ].prefix ),
99+ self .define ("EIGEN_TEST_HIP" , "ON" ),
100+ ]
101+ )
102+
93103 if self .spec .satisfies ("@master" ) and self .run_tests :
94104 args .append (self .define ("Boost_INCLUDE_DIR" , self .spec ["boost" ].prefix .include ))
105+
95106 return args
96107
97108 def check (self ):
0 commit comments