ssh key add testst

Author: simonLeary42

test/functional/SSHKeyAddTest.php

@@ -0,0 +1,117 @@
+<?php
+
+use PHPUnit\Framework\TestCase;
+use UnityWebPortal\lib\UnityGithub;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\MockObject\MockBuilder;
+
+class SSHKeyAddTest extends TestCase
+{
+    private function addSshKeysPaste(array $keys): void {
+        foreach ($keys as $key) {
+            post(
+                __DIR__ . "/../../webroot/panel/account.php",
+                [
+                    "form_type" => "addKey",
+                    "add_type" => "paste",
+                    "key" => $key
+                ]
+            );
+        }
+    }
+
+    private function addSshKeysImport(array $keys): void {
+        foreach ($keys as $key) {
+            $tmp = tmpfile();
+            $tmp_path = stream_get_meta_data($tmp)["uri"];
+            fwrite($tmp, $key);
+            $_FILES["keyfile"] = ["tmp_name" => $tmp_path];
+            try {
+                post(
+                    __DIR__ . "/../../webroot/panel/account.php",
+                    ["form_type" => "addKey", "add_type" => "import"]
+                );
+            } finally {
+                unlink($tmp_path);
+                unset($_FILES["keyfile"]);
+            }
+        }
+    }
+
+    private function addSshKeysGenerate(array $keys): void {
+        foreach ($keys as $key) {
+            post(
+                __DIR__ . "/../../webroot/panel/account.php",
+                [
+                    "form_type" => "addKey",
+                    "add_type" => "generate",
+                    "gen_key" => $key
+                ]
+            );
+        }
+    }
+
+    private function addSshKeysGithub(array $keys): void {
+        global $GITHUB;
+        $oldGithub = $GITHUB;
+        $GITHUB = $this->createMock(UnityGithub::class);
+        $GITHUB->method("getSshPublicKeys")->willReturn($keys);
+        try {
+            post(
+                __DIR__ . "/../../webroot/panel/account.php",
+                [
+                    "form_type" => "addKey",
+                    "add_type" => "github",
+                    "gh_user" => "foobar"
+                ]
+            );
+        } finally {
+            $GITHUB = $oldGithub;
+        }
+    }
+
+    public static function provider() {
+        $validKey = "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIB+XqO25MUB9x/pS04I3JQ7rMGboWyGXh0GUzkOrTi7a foobar";
+        $invalidKey = "foobar";
+        $methods = [
+            "addSshKeysPaste",
+            "addSshKeysImport",
+            "addSshKeysGenerate",
+            "addSshKeysGithub"
+        ];
+        $output = [];
+        foreach ($methods as $method) {
+            $output = array_merge($output, [
+                [$method, 0, []],
+                [$method, 0, [$invalidKey]],
+                [$method, 1, [$validKey]],
+                [$method, 1, [$validKey, $invalidKey]],
+                [$method, 1, [$validKey, $validKey]],
+            ]);
+        }
+        return $output;
+    }
+
+    public function getKeyCount()
+    {
+        global $USER;
+        return count($USER->getSSHKeys(true));
+    }
+
+    #[DataProvider("provider")]
+    public function testAddSshKeys(string $methodName, int $expectedKeysAdded, array $keys)
+    {
+        global $USER;
+        switchUser(...getUserHasNoSshKeys());
+        $numKeysBefore = $this->getKeyCount($USER);
+        $this->assertEquals(0, $numKeysBefore);
+        try {
+            call_user_func([SSHKeyAddTest::class, $methodName], $keys);
+            // $method($keys);
+            $numKeysAfter = $this->getKeyCount($USER);
+            $this->assertEquals($expectedKeysAdded, ($numKeysAfter - $numKeysBefore));
+        } finally {
+            $USER->setSSHKeys([]);
+        }
+    }
+}

tools/docker-dev/identity/bootstrap.ldif

@@ -13980,7 +13980,6 @@ objectclass: posixAccount
 objectclass: top
 objectclass: ldapPublicKey
 sn: Surname
-sshpublickey: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD3Rk+JhKNK4BL6EfvBpFpAklfvbhQYu5F4T3MBS+SErUn//UgVoW9Mam1H8F3cA0pkYbzgCeak9qOTvgOAoG6TihZj5ltCBWTdVJzhoAARYuJQ9mERunOndIp69helEK/lXsl++zdUb+znX3QT+oyeyb28+l96gBc8yspgUAmp1UAgR9vxoonNR33/w9D0OGa7y7W6kAhZ/itqVbHtqemZ4GB99jcsJ1ZRXbEgIJxa2Dbi+LHV4zVku7nHiFi8VVzvxejGeK545yh/Ox7JDi1Cglv43bIHlWPEz3biU9F7tevaZDV85Il2NuXN+lLVC/j1Tm9P38emMRiNN7uGDr9v
 uid: user3_org1_test
 uidnumber: 1018