Skip to content

Commit 532080f

Browse files
committed
add pre commit check for usage of die
1 parent e4fd195 commit 532080f

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

.pre-commit-config.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,3 +48,10 @@ repos:
4848
language: system
4949
files: \.php$
5050
args: [-l]
51+
- repo: local
52+
hooks:
53+
- id: assert-no-die
54+
name: Assert No Die
55+
entry: ./test/assert-no-die.bash
56+
language: system
57+
files: \.php$

test/assert-no-die.bash

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
#!/bin/bash
2+
set -euo pipefail
3+
if [[ $# -lt 1 ]]; then
4+
echo "at least one argument required" >&2
5+
exit 1
6+
fi
7+
occurrences="$(grep -H --line-number --color=always -P '\bdie\s*\(' "$@" | grep -v -P 'UnitySite::die\s*\(')" || true
8+
if [ -n "$occurrences" ]; then
9+
echo "die() is not allowed! use UnitySite::die() instead." >&2
10+
echo "$occurrences"
11+
exit 1
12+
fi

0 commit comments

Comments
 (0)