Merge branch 'main' into testing3

Author: simonLeary42

resources/lib/UnityWebhook.php

@@ -8,6 +8,7 @@ class UnityWebhook
     private $override_template_dir;
     private $url;
     private $MSG_LINKREF;
+    private $Subject; // set by template
 
     public function __construct(
         $template_dir,

test/functional/PiBecomeRequestTest.php

@@ -0,0 +1,51 @@
+<?php
+
+use PHPUnit\Framework\TestCase;
+
+class PiBecomeRequestTest extends TestCase
+{
+    private function assertNumberPiBecomeRequests(int $x)
+    {
+        global $USER, $SQL;
+        if ($x == 0) {
+            $this->assertFalse($SQL->requestExists($USER->getUID()));
+        } elseif ($x > 0) {
+            $this->assertTrue($SQL->requestExists($USER->getUID()));
+        } else {
+            throw new RuntimeError("x must not be negative");
+        }
+        $this->assertEquals($x, $this->getNumberPiBecomeRequests());
+    }
+
+    private function getNumberPiBecomeRequests()
+    {
+        global $USER, $SQL;
+        // FIXME table name, "admin" are private constants in UnitySQL
+        // FIXME "admin" should be something else
+        $stmt = $SQL->getConn()->prepare(
+            "SELECT * FROM requests WHERE uid=:uid and request_for='admin'"
+        );
+        $uid = $USER->getUID();
+        $stmt->bindParam(":uid", $uid);
+        $stmt->execute();
+        return count($stmt->fetchAll());
+    }
+
+    public function testRequestBecomePi()
+    {
+        global $USER, $SQL;
+        switchUser(...getUserNotPiNotRequestedBecomePi());
+        $this->assertFalse($USER->isPI());
+        $this->assertNumberPiBecomeRequests(0);
+        post(
+            __DIR__ . "/../../webroot/panel/account.php",
+            ["form_type" => "pi_request"]
+        );
+        $this->assertNumberPiBecomeRequests(1);
+        post(
+            __DIR__ . "/../../webroot/panel/account.php",
+            ["form_type" => "pi_request"]
+        );
+        $this->assertNumberPiBecomeRequests(1);
+    }
+}

test/phpunit-bootstrap.php

@@ -93,3 +93,8 @@ function getUserHasNoSshKeys()
 {
     return ["[email protected]", "foo", "bar", "[email protected]"];
 }
+
+function getUserNotPiNotRequestedBecomePi()
+{
+    return ["[email protected]", "foo", "bar", "[email protected]"];
+}