use strict comparison for JS (#453)

Author: simonLeary42

webroot/js/filter.js

@@ -4,7 +4,7 @@ function getQueryVariable(variable) {
   for (var i = 0; i < vars.length; i++) {
     var pair = vars[i].split("=");
 
-    if (pair[0] == variable) {
+    if (pair[0] === variable) {
       return pair[1];
     }
   }
@@ -32,15 +32,15 @@ function updateFilterInput() {
     commonFilterInputBox.style.display = "inline-block";
     commonFilterInputBox.style.visibility = "visible";
 
-    if (filter == "uid") {
+    if (filter === "uid") {
       commonFilterInputBox.placeholder =
         "Filter by " + filter.toUpperCase() + "...";
     } else {
       commonFilterInputBox.placeholder =
         "Filter by " + filter.charAt(0).toUpperCase() + filter.slice(1) + "...";
     }
 
-    if (getQueryVariable("value") != false) {
+    if (getQueryVariable("value") !== false) {
       commonFilterInputBox.value = getQueryVariable("value");
       filterRows();
     }
@@ -62,7 +62,7 @@ function updateFilterInput() {
     filter.addEventListener("click", function (e) {
       e.preventDefault();
       e.stopPropagation();
-      if (e.target.parentElement.id != getQueryVariable("filter")) {
+      if (e.target.parentElement.id !== getQueryVariable("filter")) {
         updateQueryStringParameter(
           window.location.href,
           "filter",
@@ -94,7 +94,7 @@ function filterRows() {
         row.cells[column].textContent
           .trim()
           .toLowerCase()
-          .indexOf(filterValue.toLowerCase()) == -1
+          .indexOf(filterValue.toLowerCase()) === -1
       ) {
         row.style.display = "none";
       } else {

webroot/js/global.js

@@ -49,7 +49,7 @@
       href = href.substring(href.lastIndexOf("/") + 1);
     }
 
-    if (url.indexOf(href) == 0) {
+    if (url.indexOf(href) === 0) {
       $(this).addClass("active");
     }
   });

webroot/js/sort.js

@@ -5,7 +5,7 @@
   }
   table.querySelectorAll("th").forEach(function (th) {
     th.addEventListener("click", function (e) {
-      if (th.innerHTML != "Actions") {
+      if (th.innerHTML !== "Actions") {
         if (e.target.classList.contains("filter")) {
           updateQueryStringParameter(
             window.location.href,
@@ -34,13 +34,13 @@
           table.querySelectorAll("th").forEach(function (header) {
             header.innerHTML = header.innerHTML.replace(/ ▲| ▼/, "");
           });
-          var orderSymbol = order == 1 ? "▲" : "▼";
+          var orderSymbol = order === 1 ? "▲" : "▼";
           th.innerHTML = th.innerHTML + " " + orderSymbol;
           updateQueryStringParameter(window.location.href, "sort", th.id);
           updateQueryStringParameter(
             window.location.href,
             "order",
-            order == 1 ? "asc" : "desc",
+            order === 1 ? "asc" : "desc",
           );
         }
       }
@@ -54,7 +54,7 @@ function getQueryVariable(variable) {
   for (var i = 0; i < vars.length; i++) {
     var pair = vars[i].split("=");
 
-    if (pair[0] == variable) {
+    if (pair[0] === variable) {
       return pair[1];
     }
   }
@@ -77,9 +77,9 @@ window.onload = function () {
   if (sort) {
     var sortElement = document.getElementById(sort);
     if (sortElement) {
-      if (order == "asc") {
+      if (order === "asc") {
         sortElement.click();
-      } else if (order == "desc") {
+      } else if (order === "desc") {
         sortElement.click();
         sortElement.click();
       }