Revert "UnitySite not static"

This reverts commit 01e7581.

Author: simonLeary42

resources/init.php

@@ -13,7 +13,6 @@
 use UnityWebPortal\lib\UnityRedis;
 use UnityWebPortal\lib\UnityWebhook;
 use UnityWebPortal\lib\UnityGithub;
-use UnityWebPortal\lib\UnitySite;
 
 //
 // Initialize Session
@@ -126,8 +125,6 @@
     }
 }
 
-$SITE = new UnitySite();
-
 //
 // Define vars
 //

resources/lib/UnitySite.php

@@ -6,15 +6,15 @@
 
 class UnitySite
 {
-    public function redirect($destination)
+    public static function redirect($destination)
     {
         if ($_SERVER["PHP_SELF"] != $destination) {
             header("Location: $destination");
             die("Redirect failed, click <a href='$destination'>here</a> to continue.");
         }
     }
 
-    public function removeTrailingWhitespace($arr)
+    public static function removeTrailingWhitespace($arr)
     {
         $out = array();
         foreach ($arr as $str) {
@@ -25,7 +25,7 @@ public function removeTrailingWhitespace($arr)
         return $out;
     }
 
-    public function testValidSSHKey($key_str)
+    public static function testValidSSHKey($key_str)
     {
         // key loader still throws, these just mute warnings for phpunit
         // https://github.com/phpseclib/phpseclib/issues/2079

resources/templates/header.php

@@ -1,7 +1,10 @@
 <?php
+
+use UnityWebPortal\lib\UnitySite;
+
 if (isset($SSO)) {
     if (!$_SESSION["user_exists"]) {
-        $SITE->redirect($CONFIG["site"]["prefix"] . "/panel/new_account.php");
+        UnitySite::redirect($CONFIG["site"]["prefix"] . "/panel/new_account.php");
     }
 }
 
@@ -116,7 +119,7 @@
     if (isset($_SESSION["is_admin"]) && $_SESSION["is_admin"]) {
         if ($_SERVER["REQUEST_METHOD"] == "POST" && isset($_POST["form_name"]) && $_POST["form_name"] == "clearView") {
             unset($_SESSION["viewUser"]);
-            $SITE->redirect($CONFIG["site"]["prefix"] . "/admin/user-mgmt.php");
+            UnitySite::redirect($CONFIG["site"]["prefix"] . "/admin/user-mgmt.php");
         }
 
         if (isset($_SESSION["viewUser"])) {
@@ -132,4 +135,4 @@
             echo "</div>";
         }
     }
-    ?>
+    ?>

webroot/admin/user-mgmt.php

@@ -2,6 +2,8 @@
 
 require_once __DIR__ . "/../../resources/autoload.php";
 
+use UnityWebPortal\lib\UnitySite;
+
 if (!$USER->isAdmin()) {
     throw new Exception("access denied");
 }
@@ -10,7 +12,7 @@
     switch ($_POST["form_name"]) {
         case "viewAsUser":
             $_SESSION["viewUser"] = $_POST["uid"];
-            $SITE->redirect($CONFIG["site"]["prefix"] . "/panel/account.php");
+            UnitySite::redirect($CONFIG["site"]["prefix"] . "/panel/account.php");
             break;
     }
 }

webroot/js/ajax/ssh_validate.php

@@ -1,5 +1,6 @@
 <?php
 
 require_once __DIR__ . "/../../../resources/lib/UnitySite.php";
+require_once __DIR__ . "/../../../vendor/autoload.php";
 
-echo (new UnityWebPortal\lib\UnitySite())->testValidSSHKey($_POST["key"]) ? "true" : "false";
+echo UnityWebPortal\lib\UnitySite::testValidSSHKey($_POST["key"]) ? "true" : "false";

webroot/panel/account.php

@@ -2,6 +2,8 @@
 
 require_once __DIR__ . "/../../resources/autoload.php";
 
+use UnityWebPortal\lib\UnitySite;
+
 require_once $LOC_HEADER;
 
 $invalid_ssh_dialogue = "<script type='text/javascript'>
@@ -16,7 +18,7 @@
             switch ($_POST["add_type"]) {
                 case "paste":
                     $key = $_POST["key"];
-                    if ($SITE->testValidSSHKey($key)) {
+                    if (UnitySite::testValidSSHKey($key)) {
                         array_push($added_keys, $key);
                     } else {
                         echo $invalid_ssh_dialogue;
@@ -25,7 +27,7 @@
                 case "import":
                     $keyfile = $_FILES["keyfile"]["tmp_name"];
                     $key = file_get_contents($keyfile);
-                    if ($SITE->testValidSSHKey($key)) {
+                    if (UnitySite::testValidSSHKey($key)) {
                         array_push($added_keys, $key);
                     } else {
                         echo $invalid_ssh_dialogue;
@@ -38,15 +40,15 @@
                     $gh_user = $_POST["gh_user"];
                     $keys = $GITHUB->getSshPublicKeys($gh_user);
                     foreach ($keys as $key) {
-                        if ($SITE->testValidSSHKey($key)) {
+                        if (UnitySite::testValidSSHKey($key)) {
                             array_push($added_keys, $key);
                         }
                     }
                     break;
             }
 
             if (!empty($added_keys)) {
-                $added_keys = $SITE->removeTrailingWhitespace($added_keys);
+                $added_keys = UnitySite::removeTrailingWhitespace($added_keys);
                 $totalKeys = array_merge($USER->getSSHKeys(), $added_keys);
                 $USER->setSSHKeys($totalKeys, $OPERATOR);
             }

webroot/panel/new_account.php

@@ -2,12 +2,13 @@
 
 require_once __DIR__ . "/../../resources/autoload.php";
 
+use UnityWebPortal\lib\UnitySite;
 use UnityWebPortal\lib\UnityGroup;
 
 require_once $LOC_HEADER;
 
 if ($USER->exists()) {
-    $SITE->redirect($CONFIG["site"]["prefix"] . "/panel/index.php");  // Redirect if account already exists
+    UnitySite::redirect($CONFIG["site"]["prefix"] . "/panel/index.php");  // Redirect if account already exists
 }
 
 if ($_SERVER["REQUEST_METHOD"] == "POST") {

webroot/panel/pi.php

@@ -3,6 +3,7 @@
 require_once __DIR__ . "/../../resources/autoload.php";
 
 use UnityWebPortal\lib\UnityUser;
+use UnityWebPortal\lib\UnitySite;
 
 $group = $USER->getPIGroup();