Skip to content

Commit c0ae697

Browse files
committed
update CONTRIBUTING.md
1 parent 7975929 commit c0ae697

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

CONTRIBUTING.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ When submitting pull requests, the pull request should be made to the version yo
1010

1111
This code base is currently using PHP version 7.4. All files are required to be linted with PSR-12 standard. This repository will automatically check PRs for linting compliance.
1212

13+
Whenever frontend JS limits the possible values of a user input, PHP must do the same!
14+
There's nothing stopping a user from making custom HTTP POST requests.
15+
This can be done in `webroot/panel/*.php` while parsing headers, or preferrably in `resources/lib/*.php`.
16+
For example, both frontend JS and in the `UnityUser` class make sure that a login shell contains only ASCII characters.
17+
1318
## Development Environment
1419

1520
### Setting up your Environment
@@ -51,4 +56,4 @@ The following users are available for testing:
5156

5257
### Changes to Dev Environment
5358

54-
Should the default schema of the web portal change, the `ldap/bootstrap.ldif` and `sql/bootstrap.sql` must be updated for the LDAP server and the MySQL server, respectively.
59+
Should the default schema of the web portal change, the `ldap/bootstrap.ldif` and `sql/bootstrap.sql` must be updated for the LDAP server and the MySQL server, respectively.

0 commit comments

Comments
 (0)