Skip to content

Commit d189ab6

Browse files
committed
update CONTRIBUTING.md
1 parent cb1cd8b commit d189ab6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ When submitting pull requests, the pull request should be made to the version yo
1010

1111
This code base is currently using PHP version 7.4. All files are required to be linted with PSR-12 standard. This repository will automatically check PRs for linting compliance.
1212

13-
Whenever frontend JS limits the possible values of a user input, PHP must do the same!
13+
Whenever frontend JS limits the possible values of a user input, PHP must also do the same, and tests must be written.
1414
There's nothing stopping a user from making custom HTTP POST requests.
1515
This can be done in `webroot/panel/*.php` while parsing headers, or preferrably in `resources/lib/*.php`.
16-
For example, both frontend JS and in the `UnityUser` class make sure that a login shell contains only ASCII characters.
16+
For example, both frontend JS and in the `UnityUser` class make sure that a login shell contains only ASCII characters, and this is tested in `test/functional/LoginShellSetTest.php`.
1717

1818
## Development Environment
1919

0 commit comments

Comments
 (0)