every switchUser has a fresh session by default

Author: simonLeary42

test/phpunit-bootstrap.php

@@ -15,9 +15,6 @@
 require_once __DIR__ . "/../resources/lib/UnityRedis.php";
 require_once __DIR__ . "/../resources/lib/UnityGithub.php";
 
-session_save_path(exec("mktemp -d"));
-error_log(session_save_path());
-
 global $HTTP_HEADER_TEST_INPUTS;
 $HTTP_HEADER_TEST_INPUTS = [
     '',
@@ -45,11 +42,20 @@
     mb_convert_encoding("Hello, World!", "UTF-16")
 ];
 
-function switchUser(string $eppn, string $given_name, string $sn, string $mail): void
-{
+function switchUser(
+    string $eppn,
+    string $given_name,
+    string $sn,
+    string $mail,
+    string|null $session_id = null
+): void {
     global $CONFIG, $REDIS, $LDAP, $SQL, $MAILER, $WEBHOOK, $GITHUB, $SITE, $SSO, $OPERATOR, $USER, $SEND_PIMESG_TO_ADMINS, $LOC_HEADER, $LOC_FOOTER;
     session_write_close();
-    session_id(str_replace(["_", "@", "."], "-", $eppn));
+    if (is_null($session_id)) {
+        session_id(str_replace(["_", "@", "."], "-", uniqid($eppn . "_")));
+    } else {
+        session_id($session_id);
+    }
     // session_start will be called on the first post()
     $_SERVER["REMOTE_USER"] = $eppn;
     $_SERVER["REMOTE_ADDR"] = "127.0.0.1";