Create function updatePhysicalSize.

Author: Yuncong Zhang

Runtime/editor/editor_window.cs

@@ -163,6 +163,16 @@ protected virtual TimeSpan getTime() {
 
         protected float deltaTime;
         protected float unscaledDeltaTime;
+        
+        void updatePhysicalSize() {
+            var size = this.queryWindowSize();
+            this._lastWindowWidth = size.x;
+            this._lastWindowHeight = size.y;
+            this._physicalSize = new Size(
+                this._lastWindowWidth * this._devicePixelRatio,
+                this._lastWindowHeight * this._devicePixelRatio);
+        }
+
 
         protected virtual void updateDeltaTime() {
             this.deltaTime = Time.unscaledDeltaTime;
@@ -175,19 +185,13 @@ protected virtual void updateSafeArea() {
         public void onViewMetricsChanged() {
             this._viewMetricsChanged = true;
         }
-
+        
         protected abstract bool hasFocus();
 
         public void OnEnable() {
             this._devicePixelRatio = this.queryDevicePixelRatio();
             this._antiAliasing = this.queryAntiAliasing();
-            var size = this.queryWindowSize();
-            this._lastWindowWidth = size.x;
-            this._lastWindowHeight = size.y;
-            this._physicalSize = new Size(
-                this._lastWindowWidth * this._devicePixelRatio,
-                this._lastWindowHeight * this._devicePixelRatio);
-
+            this.updatePhysicalSize();
             this.updateSafeArea();
             D.assert(this._surface == null);
             this._surface = this.createSurface();
@@ -444,12 +448,7 @@ void _updateScrollInput(float deltaTime) {
 
         public void Update() {
             if (this._physicalSize == null || this._physicalSize.isEmpty) {
-                var size = this.queryWindowSize();
-                this._lastWindowWidth = size.x;
-                this._lastWindowHeight = size.y;
-                this._physicalSize = new Size(
-                    this._lastWindowWidth * this._devicePixelRatio,
-                    this._lastWindowHeight * this._devicePixelRatio);
+                this.updatePhysicalSize();
             }
 
             this.updateDeltaTime();

Runtime/engine/UIWidgetsPanel.cs

@@ -72,6 +72,9 @@ protected override int queryAntiAliasing() {
 
         protected override Vector2 queryWindowSize() {
             var rect = this._uiWidgetsPanel.rectTransform.rect;
+            // Here we use ReferenceEquals instead of "==" due to
+            // https://blogs.unity3d.com/2014/05/16/custom-operator-should-we-keep-it/
+            // In short, "==" is overloaded for UnityEngine.Object and will bring performance issues
             if (!ReferenceEquals(this._uiWidgetsPanel.canvas, null)) {
                 var size = new Vector2(rect.width, rect.height) *
                            this._uiWidgetsPanel.canvas.scaleFactor / this._uiWidgetsPanel.devicePixelRatio;