Cleanup Warnings.

Author: Yuncong Zhang

Runtime/debugger/diagnostics.cs

@@ -5,6 +5,8 @@
 using Unity.UIWidgets.foundation;
 using Unity.UIWidgets.ui;
 
+#pragma warning disable 0659
+#pragma warning disable 0661
 namespace Unity.UIWidgets.debugger {
     public class DiagnosticsNode : IEquatable<DiagnosticsNode> {
         readonly Dictionary<string, object> _json; // todo use json class such as simple json

Runtime/flow/physical_shape_layer.cs

@@ -4,6 +4,7 @@
 using Color = Unity.UIWidgets.ui.Color;
 using Rect = Unity.UIWidgets.ui.Rect;
 
+#pragma warning disable 0414
 namespace Unity.UIWidgets.flow {
     public class PhysicalShapeLayer : ContainerLayer {
         public PhysicalShapeLayer(

Runtime/foundation/key.cs

@@ -1,6 +1,8 @@
 using System;
 using System.Collections.Generic;
 
+#pragma warning disable 0660
+#pragma warning disable 0661
 namespace Unity.UIWidgets.foundation {
     public abstract class Key {
         protected Key() {

Runtime/material/slider_theme.cs

@@ -10,6 +10,7 @@
 using Rect = Unity.UIWidgets.ui.Rect;
 using TextStyle = Unity.UIWidgets.painting.TextStyle;
 
+#pragma warning disable 0162
 namespace Unity.UIWidgets.material {
     public class SliderTheme : InheritedWidget {
         public SliderTheme(

Runtime/material/text_field.cs

@@ -445,7 +445,7 @@ public override Widget build(BuildContext context) {
                 formatters.Add(new LengthLimitingTextInputFormatter(this.widget.maxLength));
             }
 
-            bool forcePressEnabled = false;
+            // bool forcePressEnabled = false; // TODO: wait for force press is ready
             TextSelectionControls textSelectionControls = MaterialUtils.materialTextSelectionControls;;
             bool paintCursorAboveText = false;
             bool cursorOpacityAnimates = false;

Runtime/painting/fractional_offset.cs

@@ -31,23 +31,23 @@ public float dy {
             get { return (this.y + 1.0f) / 2.0f; }
         }
 
-        public readonly FractionalOffset topLeft = new FractionalOffset(0.0f, 0.0f);
+        public new readonly FractionalOffset topLeft = new FractionalOffset(0.0f, 0.0f);
 
-        public readonly FractionalOffset topCenter = new FractionalOffset(0.5f, 0.0f);
+        public new readonly FractionalOffset topCenter = new FractionalOffset(0.5f, 0.0f);
 
-        public readonly FractionalOffset topRight = new FractionalOffset(1.0f, 0.0f);
+        public new readonly FractionalOffset topRight = new FractionalOffset(1.0f, 0.0f);
 
-        public readonly FractionalOffset centerLeft = new FractionalOffset(0.0f, 0.5f);
+        public new readonly FractionalOffset centerLeft = new FractionalOffset(0.0f, 0.5f);
 
-        public readonly FractionalOffset center = new FractionalOffset(0.5f, 0.5f);
+        public new readonly FractionalOffset center = new FractionalOffset(0.5f, 0.5f);
 
-        public readonly FractionalOffset centerRight = new FractionalOffset(1.0f, 0.5f);
+        public new readonly FractionalOffset centerRight = new FractionalOffset(1.0f, 0.5f);
 
-        public readonly FractionalOffset bottomLeft = new FractionalOffset(0.0f, 1.0f);
+        public new readonly FractionalOffset bottomLeft = new FractionalOffset(0.0f, 1.0f);
 
-        public readonly FractionalOffset bottomCenter = new FractionalOffset(0.5f, 1.0f);
+        public new readonly FractionalOffset bottomCenter = new FractionalOffset(0.5f, 1.0f);
 
-        public readonly FractionalOffset bottomRight = new FractionalOffset(1.0f, 1.0f);
+        public new readonly FractionalOffset bottomRight = new FractionalOffset(1.0f, 1.0f);
 
         public static Alignment operator -(FractionalOffset a, Alignment b) {
             if (!(b is FractionalOffset)) {

Runtime/rendering/object.mixin.gen.cs

@@ -994,7 +994,7 @@ public int childCount {
             get { return this._childCount; }
         }
 
-        public bool debugValidateChild(RenderObject child) {
+        public new bool debugValidateChild(RenderObject child) {
             D.assert(() => {
                 if (!(child is ChildType)) {
                     throw new UIWidgetsError(

Runtime/rendering/paragraph.cs

@@ -10,6 +10,7 @@
 using Color = Unity.UIWidgets.ui.Color;
 using Rect = Unity.UIWidgets.ui.Rect;
 
+#pragma warning disable 0414
 namespace Unity.UIWidgets.rendering {
     public enum TextOverflow {
         /// Clip the overflowing text to fix its container.

Runtime/widgets/nested_scroll_view.cs

@@ -330,7 +330,6 @@ public ScrollDirection userScrollDirection {
         ScrollDirection _userScrollDirection = ScrollDirection.idle;
 
         public void updateUserScrollDirection(ScrollDirection value) {
-            D.assert(value != null);
             if (this.userScrollDirection == value) {
                 return;
             }
@@ -1076,7 +1075,7 @@ internal void _markNeedsLayout() {
         }
 
         public override string ToString() {
-            string extra;
+            string extra = "";
             switch (this._writers) {
                 case 0:
                     extra = ", orphan";
@@ -1088,7 +1087,7 @@ public override string ToString() {
                     break;
             }
 
-            return "$GetType()($layoutExtent$extra)";
+            return $"{this.GetType()}({this.layoutExtent}{extra})";
         }
     }
 

Tests/Editor/SceneViewTests.cs

@@ -9,6 +9,7 @@
 using UnityEngine;
 using Color = Unity.UIWidgets.ui.Color;
 
+#pragma warning disable 0618
 namespace UIWidgets.Tests {
     public class SceneViewTests {
         public static void show() {