Skip to content
This repository was archived by the owner on Apr 29, 2021. It is now read-only.

Commit 7a9466e

Browse files
committed
[Cupertino] Fix static to static readonly
1 parent 7a44acc commit 7a9466e

File tree

8 files changed

+172
-174
lines changed

8 files changed

+172
-174
lines changed

Runtime/cupertino/button.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212

1313
namespace Unity.UIWidgets.cupertino {
1414
public class CupertinoButtonUtils {
15-
public static Color _kDisabledBackground = new Color(0xFFA9A9A9);
16-
public static Color _kDisabledForeground = new Color(0xFFD1D1D1);
17-
public static EdgeInsets _kButtonPadding = EdgeInsets.all(16.0f);
18-
public static EdgeInsets _kBackgroundButtonPadding = EdgeInsets.symmetric(vertical: 14.0f, horizontal: 64.0f);
15+
public static readonly Color _kDisabledBackground = new Color(0xFFA9A9A9);
16+
public static readonly Color _kDisabledForeground = new Color(0xFFD1D1D1);
17+
public static readonly EdgeInsets _kButtonPadding = EdgeInsets.all(16.0f);
18+
public static readonly EdgeInsets _kBackgroundButtonPadding = EdgeInsets.symmetric(vertical: 14.0f, horizontal: 64.0f);
1919
}
2020

2121
public class CupertinoButton : StatefulWidget {

Runtime/cupertino/colors.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,24 @@
22

33
namespace Unity.UIWidgets.cupertino {
44
public class CupertinoColors {
5-
public static Color activeBlue = new Color(0xFF007AFF);
5+
public static readonly Color activeBlue = new Color(0xFF007AFF);
66

7-
public static Color activeGreen = new Color(0xFF4CD964);
7+
public static readonly Color activeGreen = new Color(0xFF4CD964);
88

9-
public static Color activeOrange = new Color(0xFFFF9500);
9+
public static readonly Color activeOrange = new Color(0xFFFF9500);
1010

11-
public static Color white = new Color(0xFFFFFFFF);
11+
public static readonly Color white = new Color(0xFFFFFFFF);
1212

13-
public static Color black = new Color(0xFF000000);
13+
public static readonly Color black = new Color(0xFF000000);
1414

15-
public static Color lightBackgroundGray = new Color(0xFFE5E5EA);
15+
public static readonly Color lightBackgroundGray = new Color(0xFFE5E5EA);
1616

17-
public static Color extraLightBackgroundGray = new Color(0xFFEFEFF4);
17+
public static readonly Color extraLightBackgroundGray = new Color(0xFFEFEFF4);
1818

19-
public static Color darkBackgroundGray = new Color(0xFF171717);
19+
public static readonly Color darkBackgroundGray = new Color(0xFF171717);
2020

21-
public static Color inactiveGray = new Color(0xFF8E8E93);
21+
public static readonly Color inactiveGray = new Color(0xFF8E8E93);
2222

23-
public static Color destructiveRed = new Color(0xFFFF3B30);
23+
public static readonly Color destructiveRed = new Color(0xFFFF3B30);
2424
}
2525
}

Runtime/cupertino/dialog.cs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
namespace Unity.UIWidgets.cupertino {
1515
class CupertinoDialogUtils {
16-
public static TextStyle _kCupertinoDialogTitleStyle = new TextStyle(
16+
public static readonly TextStyle _kCupertinoDialogTitleStyle = new TextStyle(
1717
fontFamily: ".SF UI Display",
1818
fontSize: 18.0f,
1919
fontWeight: FontWeight.w600,
@@ -22,7 +22,7 @@ class CupertinoDialogUtils {
2222
textBaseline: TextBaseline.alphabetic
2323
);
2424

25-
public static TextStyle _kCupertinoDialogContentStyle = new TextStyle(
25+
public static readonly TextStyle _kCupertinoDialogContentStyle = new TextStyle(
2626
fontFamily: ".SF UI Text",
2727
fontSize: 13.4f,
2828
fontWeight: FontWeight.w400,
@@ -32,7 +32,7 @@ class CupertinoDialogUtils {
3232
textBaseline: TextBaseline.alphabetic
3333
);
3434

35-
public static TextStyle _kCupertinoDialogActionStyle = new TextStyle(
35+
public static readonly TextStyle _kCupertinoDialogActionStyle = new TextStyle(
3636
fontFamily: ".SF UI Text",
3737
fontSize: 16.8f,
3838
fontWeight: FontWeight.w400,
@@ -43,7 +43,7 @@ class CupertinoDialogUtils {
4343
public const float _kCupertinoDialogWidth = 270.0f;
4444
public const float _kAccessibilityCupertinoDialogWidth = 310.0f;
4545

46-
public static BoxDecoration _kCupertinoDialogBlurOverlayDecoration = new BoxDecoration(
46+
public static readonly BoxDecoration _kCupertinoDialogBlurOverlayDecoration = new BoxDecoration(
4747
color: CupertinoColors.white,
4848
backgroundBlendMode: BlendMode.overlay
4949
);
@@ -54,14 +54,12 @@ class CupertinoDialogUtils {
5454
public const float _kMinButtonFontSize = 10.0f;
5555
public const float _kDialogCornerRadius = 12.0f;
5656
public const float _kDividerThickness = 1.0f;
57-
58-
public static Color _kDialogColor = new Color(0xC0FFFFFF);
59-
public static Color _kDialogPressedColor = new Color(0x90FFFFFF);
60-
public static Color _kButtonDividerColor = new Color(0x40FFFFFF);
61-
62-
6357
public const float _kMaxRegularTextScaleFactor = 1.4f;
6458

59+
public static readonly Color _kDialogColor = new Color(0xC0FFFFFF);
60+
public static readonly Color _kDialogPressedColor = new Color(0x90FFFFFF);
61+
public static readonly Color _kButtonDividerColor = new Color(0x40FFFFFF);
62+
6563
public static bool _isInAccessibilityMode(BuildContext context) {
6664
MediaQueryData data = MediaQuery.of(context, nullOk: true);
6765
return data != null && data.textScaleFactor > _kMaxRegularTextScaleFactor;

0 commit comments

Comments
 (0)