remove potential performance-relevant linq expr

zhuxingwei · zhuxingwei · commit c1dda041f980 · 2019-05-14T17:19:31.000+08:00
diff --git a/Runtime/flow/physical_shape_layer.cs b/Runtime/flow/physical_shape_layer.cs
@@ -77,6 +77,12 @@ public override void paint(PaintContext context) {
             context.canvas.restore();
         }
 
+        static Color _inAmbient;
+        static Color _inSpot;
+        static Color _ambientColor;
+        static Color _spotColor;
+        static Vector3 _zPlane = new Vector3();
+        static Vector3 _devLight = new Vector3();
 
         public static void drawShadow(Canvas canvas, Path path, Color color, float elevation, bool transparentOccluder,
             float dpr) {
@@ -88,19 +94,23 @@ public static void drawShadow(Canvas canvas, Path path, Color color, float eleva
             Rect bounds = path.getBounds();
             float shadow_x = (bounds.left + bounds.right) / 2f;
             float shadow_y = bounds.top - 600.0f;
-            Color inAmbient = color.withAlpha((int) (kAmbientAlpha * color.alpha));
-            Color inSpot = color.withAlpha((int) (kSpotAlpha * color.alpha));
-            Color ambientColor = null;
-            Color spotColor = null;
-            ShadowUtils.computeTonalColors(inAmbient, inSpot, ref ambientColor, ref spotColor);
+            _inAmbient = color.withAlpha((int) (kAmbientAlpha * color.alpha));
+            _inSpot = color.withAlpha((int) (kSpotAlpha * color.alpha));
+            _ambientColor = null;
+            _spotColor = null;
+            ShadowUtils.computeTonalColors(_inAmbient, _inSpot, ref _ambientColor, ref _spotColor);
+
+            _zPlane.Set(0, 0, dpr * elevation);
+            _devLight.Set(shadow_x, shadow_y, dpr * kLightHeight);
+            
             ShadowUtils.drawShadow(
                 canvas,
                 path,
-                new Vector3(0, 0, dpr * elevation),
-                new Vector3(shadow_x, shadow_y, dpr * kLightHeight),
+                _zPlane,
+                _devLight,
                 dpr * kLightRadius,
-                ambientColor,
-                spotColor,
+                _ambientColor,
+                _spotColor,
                 0
             );
         }
diff --git a/Runtime/foundation/basic_types.cs b/Runtime/foundation/basic_types.cs
@@ -146,5 +146,14 @@ public static ref T refAt<T>(this List<T> list, int index) {
         public static T[] array<T>(this List<T> list) {
             return NoAllocHelpersBridge<T>.ExtractArrayFromListT(list);
         }
+
+        public static List<T> CreateRepeatedList<T>(T value, int length) {
+            List<T> newList = new List<T>(length);
+            for (int i = 0; i < length; i++) {
+                newList.Add(value);
+            }
+
+            return newList;
+        }
     }
 }
diff --git a/Runtime/gestures/arena.cs b/Runtime/gestures/arena.cs
@@ -122,7 +122,7 @@ public void sweep(int pointer) {
                 D.assert(this._debugLogDiagnostic(
                     pointer, () => $"Winner: {state.members.First()}"));
 
-                state.members.First().acceptGesture(pointer);
+                state.members[0].acceptGesture(pointer);
                 for (int i = 1; i < state.members.Count; i++) {
                     state.members[i].rejectGesture(pointer);
                 }
@@ -206,12 +206,11 @@ void _resolveByDefault(int pointer, _GestureArena state) {
 
             D.assert(this._arenas[pointer] == state);
             D.assert(!state.isOpen);
-            List<GestureArenaMember> members = state.members;
-            D.assert(members.Count == 1);
+            D.assert(state.members.Count == 1);
             this._arenas.Remove(pointer);
             D.assert(this._debugLogDiagnostic(pointer,
                 () => $"Default winner: {state.members.First()}"));
-            state.members.First().acceptGesture(pointer);
+            state.members[0].acceptGesture(pointer);
         }
 
         void _resolveInFavorOf(int pointer, _GestureArena state, GestureArenaMember member) {
diff --git a/Runtime/gestures/lsq_resolver.cs b/Runtime/gestures/lsq_resolver.cs
@@ -8,7 +8,7 @@ class _Vector {
         internal _Vector(int size) {
             this._offset = 0;
             this._length = size;
-            this._elements = Enumerable.Repeat(0.0f, size).ToList();
+            this._elements = CollectionUtils.CreateRepeatedList(0.0f, size);
         }
 
         _Vector(List<float> values, int offset, int length) {
@@ -49,7 +49,7 @@ public float norm() {
     class _Matrix {
         internal _Matrix(int rows, int cols) {
             this._columns = cols;
-            this._elements = Enumerable.Repeat(0.0f, rows * cols).ToList();
+            this._elements = CollectionUtils.CreateRepeatedList(0.0f, rows * cols);
         }
 
         readonly int _columns;
@@ -71,7 +71,7 @@ public _Vector getRow(int row) {
 
     public class PolynomialFit {
         public PolynomialFit(int degree) {
-            this.coefficients = Enumerable.Repeat(0.0f, degree + 1).ToList();
+            this.coefficients = CollectionUtils.CreateRepeatedList(0.0f, degree + 1);
         }
 
         public readonly List<float> coefficients;
diff --git a/Runtime/gestures/multidrag.cs b/Runtime/gestures/multidrag.cs
@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using Unity.UIWidgets.async;
 using Unity.UIWidgets.foundation;
 using Unity.UIWidgets.ui;
@@ -238,7 +237,9 @@ void _removeState(int pointer) {
 
 
         public override void dispose() {
-            this._pointers.Keys.ToList().ForEach(this._removeState);
+            foreach (var key in this._pointers.Keys) {
+                this._removeState(key);
+            }
             D.assert(this._pointers.isEmpty);
             this._pointers = null;
             base.dispose();
diff --git a/Runtime/gestures/multitap.cs b/Runtime/gestures/multitap.cs
@@ -1,6 +1,4 @@
 using System.Collections.Generic;
-using System.Linq;
-using RSG.Promises;
 using Unity.UIWidgets.async;
 using Unity.UIWidgets.foundation;
 using Unity.UIWidgets.ui;
@@ -170,7 +168,9 @@ void _registerSecondTap(_TapTracker tracker) {
         }
 
         void _clearTrackers() {
-            this._trackers.Values.ToList().Each(this._reject);
+            foreach (var tracker in this._trackers.Values) {
+                this._reject(tracker);
+            }
             D.assert(this._trackers.isEmpty());
         }
 
diff --git a/Runtime/gestures/velocity_tracker.cs b/Runtime/gestures/velocity_tracker.cs
@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using Unity.UIWidgets.foundation;
 using Unity.UIWidgets.ui;
 using UnityEngine;
@@ -143,7 +142,7 @@ public class VelocityTracker {
         const int _minSampleSize = 3;
 
         readonly List<_PointAtTime> _samples =
-            Enumerable.Repeat<_PointAtTime>(null, _historySize).ToList();
+            CollectionUtils.CreateRepeatedList<_PointAtTime>(null, _historySize);
 
         int _index = 0;
 
diff --git a/Runtime/rendering/table.cs b/Runtime/rendering/table.cs
@@ -1,5 +1,4 @@
 using System.Collections.Generic;
-using System.Linq;
 using Unity.UIWidgets.foundation;
 using Unity.UIWidgets.gestures;
 using Unity.UIWidgets.painting;
@@ -268,7 +267,7 @@ public RenderTable(
             D.assert(rows == null || rows >= 0);
             D.assert(rows == null || children == null);
 
-            this._columns = columns ?? (children != null && children.isNotEmpty() ? children.First().Count : 0);
+            this._columns = columns ?? (children != null && children.isNotEmpty() ? children[0].Count : 0);
             this._rows = rows ?? 0;
             this._children = new List<RenderBox>();
             for (int i = 0; i < this._columns * this._rows; i++) {
@@ -588,7 +587,7 @@ void setChildren(List<List<RenderBox>> cells) {
             }
 
             this._children.Clear();
-            this._columns = cells.isNotEmpty() ? cells.First().Count : 0;
+            this._columns = cells.isNotEmpty() ? cells[0].Count : 0;
             this._rows = 0;
             foreach (List<RenderBox> row in cells) {
                 this.addRow(row);
@@ -923,7 +922,7 @@ protected override void performLayout() {
             }
 
             this._columnLefts = positions;
-            tableWidth = positions.Last() + widths.Last();
+            tableWidth = positions[positions.Count - 1] + widths[widths.Count - 1];
 
             this._rowTops.Clear();
             this._baselineDistance = null;
@@ -1094,7 +1093,7 @@ public override void paint(PaintingContext context, Offset offset) {
             D.assert(this._rows == this._rowTops.Count - 1);
             D.assert(this._columns == this._columnLefts.Count);
             if (this.border != null) {
-                Rect borderRect = Rect.fromLTWH(offset.dx, offset.dy, this.size.width, this._rowTops.Last());
+                Rect borderRect = Rect.fromLTWH(offset.dx, offset.dy, this.size.width, this._rowTops[this._rowTops.Count - 1]);
                 List<float> rows = this._rowTops.GetRange(1, this._rowTops.Count - 2);
                 List<float> columns = this._columnLefts.GetRange(1, this._columnLefts.Count - 1);
                 this.border.paint(context.canvas, borderRect, rows: rows, columns: columns);
diff --git a/Runtime/rendering/wrap.cs b/Runtime/rendering/wrap.cs
@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using Unity.UIWidgets.foundation;
 using Unity.UIWidgets.gestures;
 using Unity.UIWidgets.painting;
diff --git a/Runtime/ui/painting/txt/mesh_generator.cs b/Runtime/ui/painting/txt/mesh_generator.cs
@@ -1,6 +1,5 @@
 ﻿using System;
 using System.Collections.Generic;
-using System.Linq;
 using UnityEngine;
 
 namespace Unity.UIWidgets.ui {
@@ -108,12 +107,19 @@ public static long frameCount {
         public static int meshCount {
             get { return _meshes.Count; }
         }
+        
+        static readonly List<MeshKey> _keysToRemove = new List<MeshKey>();
 
         public static void tickNextFrame() {
             _frameCount++;
-            var keysToRemove = _meshes.Values.Where(info => info.timeToLive < _frameCount)
-                .Select(info => info.key).ToList();
-            foreach (var key in keysToRemove) {
+            _keysToRemove.Clear();
+            foreach (var info in _meshes.Values) {
+                if (info.timeToLive < _frameCount) {
+                    _keysToRemove.Add(info.key);
+                }
+            }
+
+            foreach (var key in _keysToRemove) {
                 _meshes.Remove(key);
             }
         }
diff --git a/Runtime/widgets/animated_switcher.cs b/Runtime/widgets/animated_switcher.cs
@@ -213,9 +213,13 @@ void _updateTransitionForEntry(_ChildEntry entry) {
         }
 
         void _rebuildOutgoingWidgetsIfNeeded() {
-            this._outgoingWidgets = this._outgoingWidgets ?? new List<Widget>(
-                                        this._outgoingEntries.Select((_ChildEntry entry) => entry.transition)
-                                    );
+            if (this._outgoingWidgets == null) {
+                this._outgoingWidgets = new List<Widget>(this._outgoingEntries.Count);
+                foreach (_ChildEntry entry in this._outgoingEntries) {
+                    this._outgoingWidgets.Add(entry.transition);
+                }
+            }
+            
             D.assert(this._outgoingEntries.Count == this._outgoingWidgets.Count);
             D.assert(this._outgoingEntries.isEmpty() ||
                      this._outgoingEntries.Last().transition == this._outgoingWidgets.Last());
diff --git a/Runtime/widgets/basic.cs b/Runtime/widgets/basic.cs
@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using UIWidgets.Runtime.rendering;
 using Unity.UIWidgets.foundation;
 using Unity.UIWidgets.painting;
@@ -2040,7 +2039,7 @@ public static RepaintBoundary wrap(Widget child, int childIndex) {
         }
 
         public static List<RepaintBoundary> wrapAll(List<Widget> widgets) {
-            List<RepaintBoundary> result = Enumerable.Repeat((RepaintBoundary) null, widgets.Count).ToList();
+            List<RepaintBoundary> result = CollectionUtils.CreateRepeatedList<RepaintBoundary>(null, widgets.Count);
             for (int i = 0; i < result.Count; ++i) {
                 result[i] = wrap(widgets[i], i);
             }
diff --git a/Runtime/widgets/drag_target.cs b/Runtime/widgets/drag_target.cs
@@ -1,5 +1,4 @@
 using System.Collections.Generic;
-using System.Linq;
 using Unity.UIWidgets.foundation;
 using Unity.UIWidgets.gestures;
 using Unity.UIWidgets.painting;
@@ -26,7 +25,12 @@ public enum DragAnchor {
     
     static class _DragUtils {
         public static List<T> _mapAvatarsToData<T>(List<_DragAvatar<T>> avatars) {
-            return avatars.Select(avatar => avatar.data).ToList();
+            List<T> ret = new List<T>(avatars.Count);
+            foreach (var avatar in avatars) {
+                ret.Add(avatar.data);
+            }
+
+            return ret;
         }
     }
 
@@ -466,7 +470,7 @@ void updateDrag(Offset globalPosition) {
             HitTestResult result = new HitTestResult();
             WidgetsBinding.instance.hitTest(result, globalPosition + this.feedbackOffset);
 
-            List<_DragTargetState<T>> targets = this._getDragTargets(result.path.ToList());
+            List<_DragTargetState<T>> targets = this._getDragTargets(result.path);
 
             bool listsMatch = false;
             if (targets.Count >= this._enteredTargets.Count && this._enteredTargets.isNotEmpty()) {
@@ -499,7 +503,7 @@ void updateDrag(Offset globalPosition) {
             this._activeTarget = newTarget;
         }
 
-        List<_DragTargetState<T>> _getDragTargets(List<HitTestEntry> path) {
+        List<_DragTargetState<T>> _getDragTargets(IList<HitTestEntry> path) {
             List<_DragTargetState<T>> ret = new List<_DragTargetState<T>>();
 
             foreach (HitTestEntry entry in path) {
diff --git a/Runtime/widgets/framework.cs b/Runtime/widgets/framework.cs
@@ -2636,7 +2636,7 @@ protected List<Element> updateChildren(List<Element> oldChildren, List<Widget> n
 
             var newChildren = oldChildren.Count == newWidgets.Count
                 ? oldChildren
-                : Enumerable.Repeat((Element) null, newWidgets.Count).ToList();
+                : CollectionUtils.CreateRepeatedList<Element>(null, newWidgets.Count);
 
             Element previousChild = null;
 
@@ -2961,7 +2961,7 @@ protected override void forgetChild(Element child) {
 
         public override void mount(Element parent, object newSlot) {
             base.mount(parent, newSlot);
-            this._children = Enumerable.Repeat((Element) null, this.widget.children.Count).ToList();
+            this._children = CollectionUtils.CreateRepeatedList<Element>(null, this.widget.children.Count);
             Element previousChild = null;
             for (int i = 0; i < this._children.Count; i += 1) {
                 Element newChild = this.inflateWidget(this.widget.children[i], previousChild);
diff --git a/Runtime/widgets/navigator.cs b/Runtime/widgets/navigator.cs
@@ -842,7 +842,9 @@ void _cancelActivePointers() {
                 });
             }
 
-            this._activePointers.ToList().ForEach(WidgetsBinding.instance.cancelPointer);
+            foreach (var pointer in this._activePointers) {
+                WidgetsBinding.instance.cancelPointer(pointer);
+            }
         }
 
         public override Widget build(BuildContext context) {
diff --git a/Runtime/widgets/scroll_controller.cs b/Runtime/widgets/scroll_controller.cs
@@ -56,7 +56,7 @@ public IPromise animateTo(float to,
             Curve curve
         ) {
             D.assert(this._positions.isNotEmpty(), () => "ScrollController not attached to any scroll views.");
-            List<IPromise> animations = Enumerable.Repeat((IPromise) null, this._positions.Count).ToList();
+            List<IPromise> animations = CollectionUtils.CreateRepeatedList<IPromise>(null, this._positions.Count);
             for (int i = 0; i < this._positions.Count; i += 1) {
                 animations[i] = this._positions[i].animateTo(to, duration: duration, curve: curve);
             }
diff --git a/Runtime/widgets/sliver.cs b/Runtime/widgets/sliver.cs
@@ -562,7 +562,9 @@ protected override void removeChildRenderObject(RenderObject child) {
 
         public override void visitChildren(ElementVisitor visitor) {
             D.assert(!this._childElements.Values.Any(child => child == null));
-            this._childElements.Values.ToList().ForEach(e => visitor(e));
+            foreach (var e in this._childElements.Values) {
+                visitor(e);
+            }
         }
 
         public override void debugVisitOnstageChildren(ElementVisitor visitor) {

Original file line number	Diff line number	Diff line change
`@@ -146,5 +146,14 @@ public static ref T refAt<T>(this List<T> list, int index) {`
`146`	`146`	`public static T[] array<T>(this List<T> list) {`
`147`	`147`	`return NoAllocHelpersBridge<T>.ExtractArrayFromListT(list);`
`148`	`148`	`}`
	`149`	`+`
	`150`	`+ public static List<T> CreateRepeatedList<T>(T value, int length) {`
	`151`	`+ List<T> newList = new List<T>(length);`
	`152`	`+ for (int i = 0; i < length; i++) {`
	`153`	`+ newList.Add(value);`
	`154`	`+ }`
	`155`	`+`
	`156`	`+ return newList;`
	`157`	`+ }`
`149`	`158`	`}`
`150`	`159`	`}`