Renamed static errors

Author: dim

bid.go

@@ -1,5 +1,9 @@
 package openrtb
 
+import (
+	"errors"
+)
+
 // ID, Impid and Price are required; all other optional.
 // If the bidder wins the impression, the exchange calls notice URL (nurl)
 // a) to inform the bidder of the win;
@@ -22,15 +26,22 @@ type Bid struct {
 	Ext     Extensions `json:"ext,omitempty"`
 }
 
+// Validation errors
+var (
+	invalidBidId    = errors.New("openrtb response: bid is missing ID")
+	invalidBidImpid = errors.New("openrtb response: bid is missing impression ID")
+	invalidBidPrice = errors.New("openrtb response: bid is missing price")
+)
+
 // Validate Bid required attributes
 func (bid *Bid) Valid() (bool, error) {
 
 	if bid.Id == nil {
-		return false, errValidationBidId
+		return false, invalidBidId
 	} else if bid.Impid == nil {
-		return false, errValidationBidImpid
+		return false, invalidBidImpid
 	} else if bid.Price == nil {
-		return false, errValidationBidPrice
+		return false, invalidBidPrice
 	}
 
 	return true, nil

response.go

@@ -5,15 +5,6 @@ import (
 	"errors"
 )
 
-var (
-	errValidationResId      = errors.New("openrtb response: missing ID")
-	errValidationResSeatbid = errors.New("openrtb response: missing seatbids")
-	errValidationSeatbidBid = errors.New("openrtb response: seatbid is missing bids")
-	errValidationBidId      = errors.New("openrtb response: bid is missing ID")
-	errValidationBidImpid   = errors.New("openrtb response: bid is missing impression ID")
-	errValidationBidPrice   = errors.New("openrtb response: bid is missing price")
-)
-
 // ID and at least one “seatbid” object is required, which contains a bid on at least one impression.
 // Other attributes are optional since an exchange may establish default values.
 // No-Bids on all impressions should be indicated as a HTTP 204 response.
@@ -33,14 +24,20 @@ func (res *Response) JSON() ([]byte, error) {
 	return json.Marshal(res)
 }
 
+// Validation errors
+var (
+	invalidResId      = errors.New("openrtb response: missing ID")
+	invalidResSeatbid = errors.New("openrtb response: missing seatbids")
+)
+
 // Validate Response required attributes
 // @return [Boolean,Error] true if response,seatbid,bid required attrs present
 func (res *Response) Valid() (bool, error) {
 
 	if res.Id == nil {
-		return false, errValidationResId
+		return false, invalidResId
 	} else if res.Seatbid == nil || len(res.Seatbid) < 1 {
-		return false, errValidationResSeatbid
+		return false, invalidResSeatbid
 	}
 
 	for _, sb := range res.Seatbid {

seatbid.go

@@ -1,5 +1,9 @@
 package openrtb
 
+import (
+	"errors"
+)
+
 // At least one of Bid is required.
 // A bid response can contain multiple “seatbid” objects, each on behalf of a different bidder seat.
 // Seatbid object can contain multiple bids each pertaining to a different impression on behalf of a seat.
@@ -13,11 +17,16 @@ type Seatbid struct {
 	Ext   Extensions `json:"ext,omiempty"`
 }
 
+// Validation errors
+var (
+	invalidSeatbidBid = errors.New("openrtb response: seatbid is missing bids")
+)
+
 // Validate Seatbid required attributes
 func (sb *Seatbid) Valid() (bool, error) {
 
 	if sb.Bid == nil || len(sb.Bid) < 1 {
-		return false, errValidationSeatbidBid
+		return false, invalidSeatbidBid
 	}
 
 	for _, bid := range sb.Bid {