impression: Specify imp.secure as json.Number to mitigate malformed bid requests (+ tests)

Author: Mark R

bidrequest_test.go

@@ -1,6 +1,7 @@
 package openrtb
 
 import (
+	"encoding/json"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 )
@@ -28,6 +29,7 @@ var _ = Describe("BidRequest", func() {
 			Imp: []Impression{
 				{
 					ID:     "1",
+					Secure: json.Number("1"),
 					Banner: &Banner{W: 300, H: 250, Pos: AdPosAboveFold, BAttr: []int{13}},
 				},
 			},

impression.go

@@ -1,6 +1,9 @@
 package openrtb
 
-import "errors"
+import (
+	"encoding/json"
+	"errors"
+)
 
 // Validation errors
 var (
@@ -16,22 +19,22 @@ var (
 // The presence of Banner, Video, and/or Native objects
 // subordinate to the Imp object indicates the type of impression being offered.
 type Impression struct {
-	ID                string    `json:"id"` // A unique identifier for this impression
-	Banner            *Banner   `json:"banner,omitempty"`
-	Video             *Video    `json:"video,omitempty"`
-	Audio             *Audio    `json:"audio,omitempty"`
-	Native            *Native   `json:"native,omitempty"`
-	Pmp               *Pmp      `json:"pmp,omitempty"`               // A reference to the PMP object containing any Deals eligible for the impression object.
-	DisplayManager    string    `json:"displaymanager,omitempty"`    // Name of ad mediation partner, SDK technology, etc
-	DisplayManagerVer string    `json:"displaymanagerver,omitempty"` // Version of the above
-	Instl             int       `json:"instl,omitempty"`             // Interstitial, Default: 0 ("1": Interstitial, "0": Something else)
-	TagID             string    `json:"tagid,omitempty"`             // IDentifier for specific ad placement or ad tag
-	BidFloor          float64   `json:"bidfloor,omitempty"`          // Bid floor for this impression in CPM
-	BidFloorCurrency  string    `json:"bidfloorcur,omitempty"`       // Currency of bid floor
-	Secure            int       `json:"secure,omitempty"`            // Flag to indicate whether the impression requires secure HTTPS URL creative assets and markup.
-	Exp               int       `json:"exp,omitempty"`               // Advisory as to the number of seconds that may elapse between the auction and the actual impression.
-	IFrameBuster      []string  `json:"iframebuster,omitempty"`      // Array of names for supportediframe busters.
-	Ext               Extension `json:"ext,omitempty"`
+	ID                string      `json:"id"` // A unique identifier for this impression
+	Banner            *Banner     `json:"banner,omitempty"`
+	Video             *Video      `json:"video,omitempty"`
+	Audio             *Audio      `json:"audio,omitempty"`
+	Native            *Native     `json:"native,omitempty"`
+	Pmp               *Pmp        `json:"pmp,omitempty"`               // A reference to the PMP object containing any Deals eligible for the impression object.
+	DisplayManager    string      `json:"displaymanager,omitempty"`    // Name of ad mediation partner, SDK technology, etc
+	DisplayManagerVer string      `json:"displaymanagerver,omitempty"` // Version of the above
+	Instl             int         `json:"instl,omitempty"`             // Interstitial, Default: 0 ("1": Interstitial, "0": Something else)
+	TagID             string      `json:"tagid,omitempty"`             // IDentifier for specific ad placement or ad tag
+	BidFloor          float64     `json:"bidfloor,omitempty"`          // Bid floor for this impression in CPM
+	BidFloorCurrency  string      `json:"bidfloorcur,omitempty"`       // Currency of bid floor
+	Secure            json.Number `json:"secure,omitempty"`            // Flag to indicate whether the impression requires secure HTTPS URL creative assets and markup.
+	Exp               int         `json:"exp,omitempty"`               // Advisory as to the number of seconds that may elapse between the auction and the actual impression.
+	IFrameBuster      []string    `json:"iframebuster,omitempty"`      // Array of names for supportediframe busters.
+	Ext               Extension   `json:"ext,omitempty"`
 }
 
 func (imp *Impression) assetCount() int {

testdata/breq.banner.json

@@ -5,6 +5,7 @@
   "imp": [
     {
       "id": "1",
+      "secure": "1",
       "banner": {
         "w": 300,
         "h": 250,