Skip to content

Commit 665256b

Browse files
authored
Merge pull request bsm#69 from EastResident/feature/video_duration_optional
Not validate "video.minduration" and "maxduration"
2 parents da7bfdf + ebea466 commit 665256b

File tree

2 files changed

+3
-18
lines changed

2 files changed

+3
-18
lines changed

video.go

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,9 @@ import (
77

88
// Validation errors
99
var (
10-
ErrInvalidVideoNoMIMEs = errors.New("openrtb: video has no mimes")
11-
ErrInvalidVideoNoLinearity = errors.New("openrtb: video linearity missing")
12-
ErrInvalidVideoNoMinDuration = errors.New("openrtb: video min-duration missing")
13-
ErrInvalidVideoNoMaxDuration = errors.New("openrtb: video max-duration missing")
14-
ErrInvalidVideoNoProtocols = errors.New("openrtb: video protocols missing")
10+
ErrInvalidVideoNoMIMEs = errors.New("openrtb: video has no mimes")
11+
ErrInvalidVideoNoLinearity = errors.New("openrtb: video linearity missing")
12+
ErrInvalidVideoNoProtocols = errors.New("openrtb: video protocols missing")
1513
)
1614

1715
// Video object must be included directly in the impression object if the impression offered
@@ -53,10 +51,6 @@ func (v *Video) Validate() error {
5351
return ErrInvalidVideoNoMIMEs
5452
} else if v.Linearity == 0 {
5553
return ErrInvalidVideoNoLinearity
56-
} else if v.MinDuration == 0 {
57-
return ErrInvalidVideoNoMinDuration
58-
} else if v.MaxDuration == 0 {
59-
return ErrInvalidVideoNoMaxDuration
6054
} else if v.Protocol == 0 && len(v.Protocols) == 0 {
6155
return ErrInvalidVideoNoProtocols
6256
}

video_test.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,6 @@ var _ = Describe("Video", func() {
5151
Expect((&Video{
5252
MIMEs: []string{"video/mp4"},
5353
}).Validate()).To(Equal(ErrInvalidVideoNoLinearity))
54-
Expect((&Video{
55-
Linearity: VideoLinearityNonLinear,
56-
MIMEs: []string{"video/mp4"},
57-
}).Validate()).To(Equal(ErrInvalidVideoNoMinDuration))
58-
Expect((&Video{
59-
MinDuration: 1,
60-
Linearity: VideoLinearityNonLinear,
61-
MIMEs: []string{"video/mp4"},
62-
}).Validate()).To(Equal(ErrInvalidVideoNoMaxDuration))
6354
Expect((&Video{
6455
MinDuration: 1,
6556
MaxDuration: 1,

0 commit comments

Comments
 (0)