Merge pull request #30 from Proxeter/remove_check_empty_assets

Removed check for empty assets to support another formats like onclick with openrtb format

Author: dim

bidrequest_test.go

@@ -67,7 +67,6 @@ var _ = Describe("BidRequest", func() {
 		Expect((&BidRequest{}).Validate()).To(Equal(ErrInvalidReqNoID))
 		Expect((&BidRequest{ID: "A"}).Validate()).To(Equal(ErrInvalidReqNoImps))
 		Expect((&BidRequest{ID: "A", Imp: []Impression{{ID: "1"}}, Site: &Site{}, App: &App{}}).Validate()).To(Equal(ErrInvalidReqMultiInv))
-		Expect((&BidRequest{ID: "A", Imp: []Impression{{ID: "1"}}}).Validate()).To(Equal(ErrInvalidImpNoAssets))
 
 		Expect((&BidRequest{ID: "A", Imp: []Impression{{ID: "1", Banner: &Banner{}}}}).Validate()).NotTo(HaveOccurred())
 		Expect((&BidRequest{ID: "A", Imp: []Impression{{ID: "1", Banner: &Banner{}}}, Site: &Site{}}).Validate()).NotTo(HaveOccurred())

impression.go

@@ -5,7 +5,6 @@ import "errors"
 // Validation errors
 var (
 	ErrInvalidImpNoID        = errors.New("openrtb: impression ID missing")
-	ErrInvalidImpNoAssets    = errors.New("openrtb: impression has no assets")       // neither Banner, nor Video, nor Native
 	ErrInvalidImpMultiAssets = errors.New("openrtb: impression has multiple assets") // at least two out of Banner, Video, Native
 )
 
@@ -55,9 +54,7 @@ func (imp *Impression) Validate() error {
 		return ErrInvalidImpNoID
 	}
 
-	if count := imp.assetCount(); count == 0 {
-		return ErrInvalidImpNoAssets
-	} else if count > 1 {
+	if count := imp.assetCount(); count > 1 {
 		return ErrInvalidImpMultiAssets
 	}
 

impression_test.go

@@ -36,7 +36,6 @@ var _ = Describe("Impression", func() {
 
 	It("should validate", func() {
 		Expect((&Impression{}).Validate()).To(Equal(ErrInvalidImpNoID))
-		Expect((&Impression{ID: "IMPID"}).Validate()).To(Equal(ErrInvalidImpNoAssets))
 		Expect((&Impression{ID: "IMPID", Banner: &Banner{}, Video: &Video{}}).Validate()).To(Equal(ErrInvalidImpMultiAssets))
 		Expect((&Impression{ID: "IMPID", Banner: &Banner{}}).Validate()).NotTo(HaveOccurred())
 	})