chore(deps): upgrade ureq to v3

Author: Rudxain

Cargo.lock

@@ -30,7 +30,7 @@ log = "^0.4"
 regex = "^1.10.2"
 toml = "^0"
 dirs = "^6"
-ureq = { version = "2", features = ["json"] }
+ureq = { version = "3", features = ["json"] }
 retry = "^2.0.0"
 iced = { version = "^0.12.0", features = ["advanced", "image"] }
 rfd = "^0.15"

Cargo.toml

@@ -206,19 +206,28 @@ pub fn load_debloat_lists(remote: bool) -> Result<PackageHashMap, PackageHashMap
     let mut error = false;
     let list: PackageHashMap = if remote {
         retry(Fixed::from_millis(1000).take(60), || {
-            match ureq::get(
-                &format!("https://raw.githubusercontent.com/Universal-Debloater-Alliance/universal-android-debloater/\
-           main/resources/assets/{LIST_FNAME}"),
-            )
+            match ureq::get(format!(
+                "https://raw.githubusercontent.com\
+                    /Universal-Debloater-Alliance\
+                    /universal-android-debloater\
+                    /main\
+                    /resources\
+                    /assets\
+                    /{LIST_FNAME}"
+            ))
             .call()
             {
-                Ok(data) => {
-                    // TODO: max resp size is 10MB, list is ~1.3MB;
-                    // TODO: https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/discussions/608
-                    #[warn(clippy::expect_used, reason = "this will panic if GH servers rate-limit the user, or many other reasons.")]
-                    let text = data.into_string().expect("response should be Ok type");
+                Ok(mut data) => {
+                    // https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/discussions/608
+                    let text = data
+                        .body_mut()
+                        .with_config()
+                        .limit(1 << (3 + 10 + 10))
+                        .read_to_string()
+                        .expect("remote list is bigger than 8MiB");
                     fs::write(cached_uad_lists.clone(), &text).expect("Unable to write file");
-                    let list: PackageHashMap = serde_json::from_str(&text).expect("Unable to parse");
+                    let list: PackageHashMap =
+                        serde_json::from_str(&text).expect("Unable to parse");
                     OperationResult::Ok(list)
                 }
                 Err(e) => {

src/core/uad_lists.rs

@@ -52,17 +52,24 @@ impl std::fmt::Display for SelfUpdateStatus {
     }
 }
 
-/// Download a file from the internet
+/// Download a small file from the internet
 #[cfg(feature = "self-update")]
 #[allow(clippy::unused_async, reason = "`.call` is equivalent to `.await`")]
 pub async fn download_file(url: &str, dest_file: PathBuf) -> Result<(), String> {
     debug!("downloading file from {url}");
 
     match ureq::get(url).call() {
-        Ok(res) => {
+        Ok(mut res) => {
             let mut file = fs::File::create(dest_file).map_err(|e| e.to_string())?;
 
-            if let Err(e) = copy(&mut res.into_reader(), &mut file) {
+            if let Err(e) = copy(
+                &mut res
+                    .body_mut()
+                    .with_config()
+                    .limit(1 << 26) // 64MiB
+                    .as_reader(),
+                &mut file,
+            ) {
                 return Err(e.to_string());
             }
         }
@@ -175,10 +182,10 @@ pub fn get_latest_release() -> Result<Option<Release>, ()> {
 pub fn get_latest_release() -> Result<Option<Release>, ()> {
     debug!("Checking for {NAME} update");
 
-    if let Ok(res) = ureq::get("https://api.github.com/repos/Universal-Debloater-Alliance/universal-android-debloater/releases/latest")
+    if let Ok(mut res) = ureq::get("https://api.github.com/repos/Universal-Debloater-Alliance/universal-android-debloater/releases/latest")
         .call() {
         let release: Release = serde_json::from_value(
-            res.into_json::<serde_json::Value>()
+            res.body_mut().read_json::<serde_json::Value>()
                 .map_err(|_| ())?
                 .clone(),
         )