time data fixes and validation

Author: seveibar

src/components/ReactTimeSeries/index.js

@@ -11,7 +11,7 @@ import MainLayout from "../MainLayout"
 import fetchAudioData from "../../utils/fetch-audio-data"
 import fetchCSVData from "../../utils/fetch-csv-data"
 
-import validateTimeData from "../../utils/validate-time-data"
+import fixTimeData from "../../utils/fix-time-data"
 
 const emptyAr = []
 
@@ -52,13 +52,18 @@ export const ReactTimeSeriesWithoutContext = ({
 
   const timeDataAvailable = [sampleTimeData, audioUrl, csvUrl].some(Boolean)
 
+  const [error, setError] = useState(null)
   const timeData = useAsyncMemo(
     async () => {
-      if (sampleTimeData) return validateTimeData(sampleTimeData)
-      if (audioUrl) return validateTimeData(await fetchAudioData(audioUrl))
-      if (csvUrl) return validateTimeData(await fetchCSVData(csvUrl))
-      return []
-      // TODO load csvUrl
+      try {
+        if (sampleTimeData) return fixTimeData(sampleTimeData, graphs)
+        if (audioUrl) return fixTimeData(await fetchAudioData(audioUrl), graphs)
+        if (csvUrl) return fixTimeData(await fetchCSVData(csvUrl), graphs)
+        return []
+      } catch (e) {
+        setError(e)
+        return []
+      }
     },
     [sampleTimeData, audioUrl, csvUrl],
     null
@@ -200,6 +205,10 @@ export const ReactTimeSeriesWithoutContext = ({
     throw new Error(`For some reason, no curves are able to be displayed.`)
   }
 
+  if (error) {
+    throw error
+  }
+
   return (
     <Measure bounds onResize={onResize}>
       {({ measureRef }) => (

src/utils/fix-time-data.js

@@ -0,0 +1,40 @@
+export default (timeData, graphs) => {
+  // Make sure that all points have time, and time is always a number
+  for (const sample of timeData) {
+    if (sample.time === undefined || sample.time === null)
+      throw new Error(`Undefined time for sample\n\n${JSON.stringify(sample)}`)
+    if (typeof sample.time === "string") {
+      const ogTime = sample.time
+      if (isNaN(ogTime)) {
+        sample.time = new Date(sample.time).valueOf()
+      } else {
+        sample.time = parseFloat(sample.time)
+      }
+      if (isNaN(sample.time)) {
+        throw new Error(`Couldn't parse time "${sample.time}"`)
+      }
+    }
+    if (isNaN(sample.time)) throw new Error("Time must be a number")
+  }
+
+  // Make sure that timeData has a value in each datapoint for
+  // each graph (or explicitly doesn't define it w/ undefined)
+  // No NaNs allowed
+  for (const graph of graphs) {
+    let pointsDefined = 0
+
+    for (const sample of timeData) {
+      const v = sample[graph.keyName]
+      if (v !== undefined && v !== null && isNaN(v))
+        throw new Error(`Bad value for "${graph.keyName}": "${v}"`)
+      pointsDefined++
+    }
+
+    if (pointsDefined < 2)
+      throw new Error(
+        `Less than two points defined for the "${graph.keyName}" graph`
+      )
+  }
+
+  return timeData
+}