added default for cors proxy even for previously saved configs

Author: seveibar

src/components/AddAuthFromTemplateDialog/index.js

@@ -108,13 +108,10 @@ const forms = {
     questions: [
       {
         name: "auth.proxy.corsproxy",
+        type: "text",
         title: "CORS Proxy",
         description:
           "Some requests for images or APIs (like AWS S3) are blocked by browsers for security reasons, this CORs proxy will be used to enable blocked functionality when not using the desktop application.",
-        defaultValue:
-          // TODO this is currently deployed on @seveibar's cloudflare, it'd be
-          // better if it was deployed on the organization's cloudflare
-          "https://corsproxy.seve.workers.dev/corsproxy/?apiurl={URL}",
       },
     ],
   },
@@ -131,7 +128,10 @@ export default ({ open, onClose, onSelect, onFinish, onAuthConfigured }) => {
     const questionIds = form.questions.map((q) => q.name)
     const defaults = {}
     for (const questionId of questionIds) {
-      defaults[questionId] = fromConfig(questionId)
+      const configValue = fromConfig(questionId)
+      if (configValue !== undefined) {
+        defaults[questionId] = configValue
+      }
     }
     return defaults
   }

src/components/AppConfig/index.js

@@ -14,11 +14,19 @@ const configKeyNames = [
   "auth.cognito.storage.aws_s3.region",
   "auth.s3iam.access_key_id",
   "auth.s3iam.secret_access_key",
+  "auth.proxy.corsproxy",
   "labelhelp.disabled",
   "labelhelp.apikey",
   ...defaultHotkeys.map(({ id }) => `hotkeys.${id}`),
 ]
 
+const defaultAppConfig = {
+  "auth.proxy.corsproxy":
+    // TODO this is currently deployed on @seveibar's cloudflare, it'd be
+    // better if it was deployed on the organization's cloudflare
+    "https://corsproxy.seve.workers.dev/corsproxy/?apiurl={URL}",
+}
+
 // NOTE: appConfig should not allow any nested values
 export const AppConfigContext = createContext({
   appConfig: {},
@@ -39,6 +47,9 @@ export const AppConfigProvider = ({ children }) => {
         if (!configKeyNames.includes(key)) {
           throw new Error(`Unknown config key name "${key}"`)
         }
+        if (appConfig[key] === undefined) {
+          return defaultAppConfig[key]
+        }
         return appConfig[key]
       },
       setInConfig: (key, value) => {